buildcheck: reduce DEBUG_INFO noise from reference* scripts
PATCH 1/1 buildcheck: reduce DEBUG_INFO noise from reference* scripts
Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.
diffstat:=
scripts/reference_discarded.pl | 3 +++ scripts/reference_init.pl | 1 + 2 files changed, 4 insertions(+)
scripts/reference_discarded.pl renamed from scripts/reference_discarded.pl~ref_init_debugs +3 -0
@@ -82,6 +82,8 @@ foreach $object (keys(%object)) { } if (($line =~ /\.text\.exit$/ || $line =~ /\.exit\.text$/ || + $line =~ /\.text\.init$/ || + $line =~ /\.init\.text$/ || $line =~ /\.data\.exit$/ || $line =~ /\.exit\.data$/ || $line =~ /\.exitcall\.exit$/) &&
@@ -96,6 +98,7 @@ foreach $object (keys(%object)) { $from !~ /\.debug_ranges$/ && $from !~ /\.debug_line$/ && $from !~ /\.debug_frame$/ && + $from !~ /\.debug_loc$/ && $from !~ /\.exitcall\.exit$/ && $from !~ /\.eh_frame$/ && $from !~ /\.stab$/)) {
scripts/reference_init.pl renamed from scripts/reference_init.pl~ref_init_debugs +1 -0
@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) { $from !~ /\.pdr$/ && $from !~ /\__param$/ && $from !~ /\.altinstructions/ && + $from !~ /\.eh_frame/ && $from !~ /\.debug_/)) { printf("Error: %s %s refers to %s\n", $object, $from, $line); }
---
Quoted 2 lines · Randy.Dunlap
Reduce noise in 'make buildcheck' that is caused by
CONFIG_DEBUG_INFO=y.
Applied to my kbuild tree.
Sam
Quoted 35 lines · Randy.Dunlap
Reduce noise in 'make buildcheck' that is caused by
CONFIG_DEBUG_INFO=y.Signed-off-by Randy Dunlap <[email protected]>diffstat:=
scripts/reference_discarded.pl | 3 +++ scripts/reference_init.pl | 1 + 2 files changed, 4 insertions(+)diff -Naurp
./scripts/reference_discarded.pl~ref_init_debugs./scripts/reference_discarded.plscripts/reference_discarded.pl renamed from scripts/reference_discarded.pl~ref_init_debugs +3
-0@@ -82,6 +82,8 @@ foreach $object (keys(%object)) { } if (($line =~ /\.text\.exit$/ || $line =~ /\.exit\.text$/ || + $line =~ /\.text\.init$/ || + $line =~ /\.init\.text$/ || $line =~ /\.data\.exit$/ || $line =~ /\.exit\.data$/ || $line =~ /\.exitcall\.exit$/) &&@@ -96,6 +98,7 @@ foreach $object (keys(%object)) { $from !~ /\.debug_ranges$/ && $from !~ /\.debug_line$/ && $from !~ /\.debug_frame$/ && + $from !~ /\.debug_loc$/ && $from !~ /\.exitcall\.exit$/ && $from !~ /\.eh_frame$/ && $from !~ /\.stab$/)) {diff -Naurp
./scripts/reference_init.pl~ref_init_debugs./scripts/reference_init.pl
scripts/reference_init.pl foreach $object (sort(keys(%object))) { · line 104
Quoted 7 lines
scripts/reference_init.pl renamed from scripts/reference_init.pl~ref_init_debugs +1
-0@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) { $from !~ /\.pdr$/ && $from !~ /\__param$/ && $from !~ /\.altinstructions/ && + $from !~ /\.eh_frame/ && $from !~ /\.debug_/)) { printf("Error: %s %s refers to %s\n", $object, $from, $line); }
Adding .debug_loc and .eh_frame to the exclude lists is fine. But why add .text.init and .init.text to the selection list in reference_discarded.pl? reference_discarded.pl only looks at exit sections, not init sections. reference_init.pl already handles the init sections.
Quoted 42 lines · Keith Owens
Quoted 40 lines · Randy.Dunlap
Reduce noise in 'make buildcheck' that is caused by
CONFIG_DEBUG_INFO=y.Signed-off-by Randy Dunlap <[email protected]>diffstat:=
scripts/reference_discarded.pl | 3 +++ scripts/reference_init.pl | 1 + 2 files changed, 4 insertions(+)diff -Naurp
./scripts/reference_discarded.pl~ref_init_debugs./scripts/reference_discarded.plscripts/reference_discarded.pl renamed from scripts/reference_discarded.pl~ref_init_debugs +3
-0@@ -82,6 +82,8 @@ foreach $object (keys(%object)) { } if (($line =~ /\.text\.exit$/ || $line =~ /\.exit\.text$/ || + $line =~ /\.text\.init$/ || + $line =~ /\.init\.text$/ || $line =~ /\.data\.exit$/ || $line =~ /\.exit\.data$/ || $line =~ /\.exitcall\.exit$/) &&@@ -96,6 +98,7 @@ foreach $object (keys(%object)) { $from !~ /\.debug_ranges$/ && $from !~ /\.debug_line$/ && $from !~ /\.debug_frame$/ && + $from !~ /\.debug_loc$/ && $from !~ /\.exitcall\.exit$/ && $from !~ /\.eh_frame$/ && $from !~ /\.stab$/)) {diff -Naurp
./scripts/reference_init.pl~ref_init_debugs./scripts/reference_init.plscripts/reference_init.pl renamed from scripts/reference_init.pl~ref_init_debugs +1
-0@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) { $from !~ /\.pdr$/ && $from !~ /\__param$/ && $from !~ /\.altinstructions/ && + $from !~ /\.eh_frame/ && $from !~ /\.debug_/)) { printf("Error: %s %s refers to %s\n", $object, $from, $line); }
Quoted 8 lines
Quoted 1 line
Adding .debug_loc and .eh_frame to the exclude lists is fine. But why add .text.init and .init.text to the selection list in reference_discarded.pl? reference_discarded.pl only looks at exit sections, not init sections. reference_init.pl already handles the init sections.
Indeed, it's actually much worse with that patch section added. :( I don't know how I got there.
Sam, can you drop the very first patch section here, or shall I send a new patch for this?
Signature · 1 line
~Randy
On Mon, Mar 14, 2005 at 01:38:11PM -0800, Randy.Dunlap wrote:
Indeed, it's actually much worse with that patch section added. :(
Quoted 4 lines
I don't know how I got there.
Sam, can you drop the very first patch section here, or shall I send a new patch for this?
Incremental patch please. I already have a few patches on top of this in bitkeeper.
Sam
Quoted 5 lines · Sam Ravnborg
On Mon, Mar 14, 2005 at 01:38:11PM -0800, Randy.Dunlap wrote:
Indeed, it's actually much worse with that patch section added. :(Quoted 2 lines
I don't know how I got there.
Quoted 7 lines
Quoted 2 lines
Sam, can you drop the very first patch section here, or shall I send a new patch for this?
Incremental patch please. I already have a few patches on top of this in bitkeeper.
Sam
Here you go.... back out those 2 lines.
Thanks,
Signature · 1 line
~Randy
I should not have added init.text test here; it's more than useless, it actually degrades the output.
diffstat:=
scripts/reference_discarded.pl | 2 -- 1 files changed, 2 deletions(-)
scripts/reference_discarded.pl renamed from scripts/reference_discarded.pl~refer_discard_no_init +0 -2
@@ -82,8 +82,6 @@ foreach $object (keys(%object)) { } if (($line =~ /\.text\.exit$/ || $line =~ /\.exit\.text$/ || - $line =~ /\.text\.init$/ || - $line =~ /\.init\.text$/ || $line =~ /\.data\.exit$/ || $line =~ /\.exit\.data$/ || $line =~ /\.exitcall\.exit$/) &&