Skip to contentSkip to conversation

mtd: use unsigned 1-bit fields

PATCH In review Randy.Dunlap 2 participants 3 messages Mar 15, 2005 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: use unsigned 1-bit fields

(resend)

Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield

diffstat:=

 include/linux/mtd/flashchip.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mtd/flashchip.h renamed from include/linux/mtd/flashchip.h~mtd_flashchip_bool +2 -2
diff -Naurp ./include/linux/mtd/flashchip.h~mtd_flashchip_bool ./include/linux/mtd/flashchip.h
@@ -62,8 +62,8 @@ struct flchip {
 	flstate_t state;
 	flstate_t oldstate;
 
-	int write_suspended:1;
-	int erase_suspended:1;
+	unsigned int write_suspended:1;
+	unsigned int erase_suspended:1;
 	unsigned long in_progress_block_addr;
 
 	spinlock_t *mutex;

---

#1 lore raw
Quoted 5 lines · Randy.Dunlap

(resend)

Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield

caught in the mtd-cvs, so it depends if you want to wait for the next mtd merge or not.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#2 lore raw
Quoted 11 lines · Ben Dooks
Quoted 5 lines · Randy.Dunlap

(resend)

Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield

caught in the mtd-cvs, so it depends if you want to wait for the next mtd merge or not.

That's fine by me. I didn't know it had made it to the mtd-cvs.

Thanks for the message.

Signature · 1 line
~Randy