Skip to contentSkip to conversation

s1d13xxxfb: Add support for Epson S1D13806 FB

PATCH In review Antonino A. Daplas 2 participants 4 messages Mar 14, 2005 – Mar 15, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 s1d13xxxfb: Add support for Epson S1D13806 FB

Attached to that mail is a patch adding support for Epson S1D13806 framebuffer device.

That driver is intended to be easily used with other S1D13xxx devices, hopefully by splitting the header file and changing a few defines. Since I haven't got the hardware to test that, though, I can only assert that it works with S1D13806.

This driver has been succesfully tested on ARM embedded boards and reported working on SH architecture as well.

Since this is my first framebuffer driver, I would welcome any suggestion/comment about it :)

This driver has been built on top of some preliminary ARM specific work by Ben Dooks, and adapted from existing code (as stated in the header of s1d13xxxfb.c).

---

 drivers/video/Kconfig      |   12
 drivers/video/Makefile     |    1
 drivers/video/s1d13xxxfb.c |  772 +++++++++++++++++++++++++++++++++++++++++++++
 include/video/s1d13xxxfb.h |  166 +++++++++
 4 files changed, 951 insertions(+)
drivers/video/Kconfig +12 -0
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
@@ -1448,6 +1448,18 @@
 
 	  <file:Documentation/fb/pxafb.txt> describes the available parameters.
 
+config FB_S1D13XXX
+	tristate "Epson S1D13XXX framebuffer support"
+	depends on FB
+	select FB_CFB_FILLRECT
+	select FB_CFB_COPYAREA
+	select FB_CFB_IMAGEBLIT
+	select FB_SOFT_CURSOR
+	help
+	  Support for S1D13XXX framebuffer device family (currently only
+	  working with S1D13806). Product specs at
+	  <http://www.erd.epson.com/vdc/html/legacy_13xxx.htm>
+
 config FB_VIRTUAL
 	tristate "Virtual Frame Buffer support (ONLY FOR TESTING!)"
 	depends on FB
drivers/video/Makefile +1 -0
diff -Nru a/drivers/video/Makefile b/drivers/video/Makefile
@@ -89,6 +89,7 @@
 obj-$(CONFIG_FB_PMAGB_B)	  += pmagb-b-fb.o
 obj-$(CONFIG_FB_MAXINE)		  += maxinefb.o
 obj-$(CONFIG_FB_TX3912)		  += tx3912fb.o
+obj-$(CONFIG_FB_S1D13XXX)	  += s1d13xxxfb.o
 
 # Platform or fallback drivers go here
 obj-$(CONFIG_FB_VESA)             += vesafb.o
drivers/video/s1d13xxxfb.c new file +772 -0

772 lines not on this page · raw message

include/video/s1d13xxxfb.h new file +166 -0

166 lines not on this page · raw message

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#1 lore raw
Quoted 15 lines · Antonino A. Daplas

Attached to that mail is a patch adding support for Epson S1D13806
framebuffer device.

That driver is intended to be easily used with other S1D13xxx devices, hopefully by splitting the header file and changing a few defines. Since I haven't got the hardware to test that, though, I can only assert that it works with S1D13806.

This driver has been succesfully tested on ARM embedded boards and reported working on SH architecture as well.

Since this is my first framebuffer driver, I would welcome any suggestion/comment about it :)

Quoted 6 lines

This driver has been built on top of some preliminary ARM specific work by Ben Dooks, and adapted from existing code (as stated in the header of s1d13xxxfb.c).

I've been going around editing From: lines recently, in cases where it's obvious. I did so with this patch - please let me know if that is inappropariate.

So the patch will hit bk as:

From: Thibaut VARENE <[email protected]>

So

a) Thibaut will be identified in the bk logs as the author

b) His name will appear in the short-form changelogs, etc.

c) The Signed-off-by: line will note that Tony and I also handled this patch, and possibly made small changes to it.

I do this so that contributors get suitable credit, and so that bug reporters have a better chance of finding who to email on the first attempt.

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#2 lore raw
Quoted 19 lines · Andrew Morton
Quoted 18 lines · Antonino A. Daplas

Attached to that mail is a patch adding support for Epson S1D13806
framebuffer device.

That driver is intended to be easily used with other S1D13xxx devices, hopefully by splitting the header file and changing a few defines.
Since I haven't got the hardware to test that, though, I can only assert that it works with S1D13806.

This driver has been succesfully tested on ARM embedded boards and reported working on SH architecture as well.

Since this is my first framebuffer driver, I would welcome any suggestion/comment about it :)

This driver has been built on top of some preliminary ARM specific
work by Ben Dooks, and adapted from existing code (as stated in the header of s1d13xxxfb.c).

Quoted 6 lines
Quoted 2 lines

I've been going around editing From: lines recently, in cases where it's obvious. I did so with this patch - please let me know if that is inappropariate.

No, this is okay.

Quoted 14 lines

So the patch will hit bk as:

From: Thibaut VARENE <[email protected]>

So

a) Thibaut will be identified in the bk logs as the author

Quoted 9 lines

b) His name will appear in the short-form changelogs, etc.

c) The Signed-off-by: line will note that Tony and I also handled this patch, and possibly made small changes to it.

I do this so that contributors get suitable credit, and so that bug reporters have a better chance of finding who to email on the first attempt.

With the patches I send you, the first one in the signed-off line is the original contributor of the patch and the changelog. If the original contributor did not sign-off, I add a 'From: <author>' with or without the e-mail address at the very beginning of the changelog.

Anyway, would you like to me to follow the format below to make it easier for you?

Quoted 4 lines

From: Thibaut VARENE <[email protected]>

Tony

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#3 lore raw
Quoted 3 lines · Antonino A. Daplas

Anyway, would you like to me to follow the format below to make it
easier for you?

Please. The patches which I send to Linus are in what I consider to be "canonical form". If I receive a patch which starts out with

From: John Doe <[email protected]>

Then I'll arrange for John to propagate into bk as the submitter.

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click