Skip to contentSkip to conversation

net/802/fc.c: #if 0 fc_type_trans

PATCH In review Adrian Bunk 2 participants 4 messages Mar 6, 2005 – Mar 15, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 net/802/fc.c: #if 0 fc_type_trans

The only user of fc_type_trans (drivers/net/fc/iph5526.c) is BROKEN in 2.6 and removed in -mm.

Signed-off-by Adrian Bunk <[email protected]>

---

 include/linux/fcdevice.h |    2 --
 net/802/fc.c             |    2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/fcdevice.h renamed from include/linux/fcdevice.h.old +0 -2
@@ -24,12 +24,10 @@
 #define _LINUX_FCDEVICE_H
 
 
 #include <linux/if_fc.h>
 
 #ifdef __KERNEL__
-extern unsigned short	fc_type_trans(struct sk_buff *skb, struct net_device *dev); 
-
 extern struct net_device *alloc_fcdev(int sizeof_priv);
 #endif
 
 #endif	/* _LINUX_FCDEVICE_H */
net/802/fc.c renamed from net/802/fc.c.old +2 -0
@@ -94,12 +94,13 @@
 	return arp_find(fch->daddr, skb);
 #else
 	return 0;
 #endif
 }
 
+#if 0
 unsigned short
 fc_type_trans(struct sk_buff *skb, struct net_device *dev)
 {
 	struct fch_hdr *fch = (struct fch_hdr *)skb->data;
 	struct fcllc *fcllc;
 

@@ -127,12 +128,13 @@
 		skb_pull(skb, sizeof (struct fcllc));
 		return fcllc->ethertype;
 	}
 
 	return ntohs(ETH_P_802_2);
 }
+#endif  /*  0  */
 
 static void fc_setup(struct net_device *dev)
 {
 	dev->hard_header	= fc_header;
 	dev->rebuild_header	= fc_rebuild_header;
maintainer
#1 lore raw
Quoted 4 lines · On Sun, 6 Mar 2005 21:57:54 +0100 Adrian Bunk <[email protected]> wrote:

The only user of fc_type_trans (drivers/net/fc/iph5526.c) is BROKEN in 2.6 and removed in -mm.

Signed-off-by Adrian Bunk <[email protected]>

That driver isn't in Linus's tree any longer either. Just delete the thing altogether instead of #if 0'ing it.

Thanks.

author
#2 lore raw

PATCH 1/1 net/802/fc.c: remove fc_type_trans

Quoted 11 lines · David S. Miller
Quoted 4 lines · On Sun, 6 Mar 2005 21:57:54 +0100 Adrian Bunk <[email protected]> wrote:

The only user of fc_type_trans (drivers/net/fc/iph5526.c) is BROKEN in 2.6 and removed in -mm.

Signed-off-by Adrian Bunk <[email protected]>

That driver isn't in Linus's tree any longer either. Just delete the thing altogether instead of #if 0'ing it.
...

Updated patch:

<-- snip -->

The only user of fc_type_trans (drivers/net/fc/iph5526.c) is removed in Linus' tree.

Signed-off-by Adrian Bunk <[email protected]>

---

 include/linux/fcdevice.h |    2 --
 net/802/fc.c             |   34 ----------------------------------
 2 files changed, 36 deletions(-)
include/linux/fcdevice.h renamed from include/linux/fcdevice.h.old +0 -2
@@ -24,12 +24,10 @@
 #define _LINUX_FCDEVICE_H
 
 
 #include <linux/if_fc.h>
 
 #ifdef __KERNEL__
-extern unsigned short	fc_type_trans(struct sk_buff *skb, struct net_device *dev); 
-
 extern struct net_device *alloc_fcdev(int sizeof_priv);
 #endif
 
 #endif	/* _LINUX_FCDEVICE_H */
net/802/fc.c renamed from net/802/fc.c.old +0 -34
@@ -97,40 +97,6 @@
 #endif
 }
 
-unsigned short
-fc_type_trans(struct sk_buff *skb, struct net_device *dev)
-{
-	struct fch_hdr *fch = (struct fch_hdr *)skb->data;
-	struct fcllc *fcllc;
-
-	skb->mac.raw = skb->data;
-	fcllc = (struct fcllc *)(skb->data + sizeof (struct fch_hdr) + 2);
-	skb_pull(skb, sizeof (struct fch_hdr) + 2);
-
-	if (*fch->daddr & 1) {
-		if (!memcmp(fch->daddr, dev->broadcast, FC_ALEN))
-			skb->pkt_type = PACKET_BROADCAST;
-		else
-			skb->pkt_type = PACKET_MULTICAST;
-	} else if (dev->flags & IFF_PROMISC) {
-		if (memcmp(fch->daddr, dev->dev_addr, FC_ALEN))
-			skb->pkt_type = PACKET_OTHERHOST;
-	}
-
-	/*
-	 * Strip the SNAP header from ARP packets since we don't pass
-	 * them through to the 802.2/SNAP layers.
-	 */
-	if (fcllc->dsap == EXTENDED_SAP &&
-	    (fcllc->ethertype == ntohs(ETH_P_IP) ||
-	     fcllc->ethertype == ntohs(ETH_P_ARP))) {
-		skb_pull(skb, sizeof (struct fcllc));
-		return fcllc->ethertype;
-	}
-
-	return ntohs(ETH_P_802_2);
-}
-
 static void fc_setup(struct net_device *dev)
 {
 	dev->hard_header	= fc_header;
maintainer Applied
#3 lore raw

Re: [2.6 patch] net/802/fc.c: remove fc_type_trans

Quoted 7 lines · On Tue, 15 Mar 2005 13:20:17 +0100 Adrian Bunk <[email protected]> wrote:
Quoted 6 lines · David S. Miller
Quoted 3 lines · On Sun, 6 Mar 2005 21:57:54 +0100 Adrian Bunk <[email protected]> wrote:

The only user of fc_type_trans (drivers/net/fc/iph5526.c) is BROKEN in 2.6 and removed in -mm.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Adrian Bunk <[email protected]>

That driver isn't in Linus's tree any longer either. Just delete the thing altogether instead of #if 0'ing it.
...

Updated patch:

Applied, thanks a lot Adrian.