Skip to contentSkip to conversation

w6692 eliminate bad section references

PATCH In review maximilian attems 2 participants 4 messages Mar 13, 2005 – Mar 15, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 w6692 eliminate bad section references

Fix w6692 section references:
convert __initdata to __devinitdata.

Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32 .init.data

diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c

drivers/isdn/hisax/w6692.c +1 -1
@@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision:
 
 #define DBUSY_TIMER_VALUE 80
 
-static char *W6692Ver[] __initdata =
+static char *W6692Ver[] __devinitdata =
 {"W6692 V00", "W6692 V01", "W6692 V10",
  "W6692 V11"};
 
#1 lore raw
Quoted 13 lines · maximilian attems

Fix w6692 section references:
convert __initdata to __devinitdata.

Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32 .init.data

diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c

drivers/isdn/hisax/w6692.c const char *w6692_revision = "$Revision: · line 51

Quoted 8 lines
drivers/isdn/hisax/w6692.c +1 -1
@@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision:
 
 #define DBUSY_TIMER_VALUE 80
 
-static char *W6692Ver[] __initdata =
+static char *W6692Ver[] __devinitdata =
 {"W6692 V00", "W6692 V01", "W6692 V10",
  "W6692 V11"};
 

I think the correct fix is to make W6692Version() be __init ... What do you think of that?

Signature · 1 line
~Randy
#2 lore raw
Quoted 12 lines · Randy.Dunlap
Quoted 6 lines · maximilian attems

Fix w6692 section references:
convert __initdata to __devinitdata.

Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32 .init.data

I think the correct fix is to make W6692Version() be __init ... What do you think of that?

Signature · 1 line
~Randy

thanks a lot for your review!
you are right much better, added __init to W6692Version().

#Signed-off-by: maximilian attems <[email protected]>

diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c

drivers/isdn/hisax/w6692.c +1 -1
@@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
 {"W6692 V00", "W6692 V01", "W6692 V10",
  "W6692 V11"};
 
-static void
+static void __init
 W6692Version(struct IsdnCardState *cs, char *s)
 {
 	int val;
Acked-by
#3 lore raw
Quoted 5 lines · maximilian attems

thanks a lot for your review!
you are right much better, added __init to W6692Version().

#Signed-off-by: maximilian attems <[email protected]>

Quoted 13 lines

diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c

drivers/isdn/hisax/w6692.c +1 -1
@@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
 {"W6692 V00", "W6692 V01", "W6692 V10",
  "W6692 V11"};
 
-static void
+static void __init
 W6692Version(struct IsdnCardState *cs, char *s)
 {
 	int val;
Signature · 1 line
~Randy