ppc32: Fix a warning in planb video driver
PATCH 1/1 ppc32: Fix a warning in planb video driver
[ aside: This has been sitting in the linuxppc-2.5 bk tree for I don't
know how long. And the driver is still horribly broken. ]
The following patch moves overlay_is_active to before its first use. It was originally written when gcc wouldn't complain, but now does, about not having the definition before usage.
drivers/media/video/planb.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-)
drivers/media/video/planb.c +10 -10
@@ -421,6 +421,16 @@/* overlay support functions */ /*****************************/ +static inline int overlay_is_active (struct planb *pb) +{ +unsigned int size = pb->tab_size *sizeof (struct dbdma_cmd ); +unsigned int caddr = (unsigned )in_le32 (&pb->planb_base->ch1.cmdptr); + +return (in_le32 (&pb->overlay_last1->cmd_dep) == pb->ch1_cmd_phys) + && (caddr < (pb->ch1_cmd_phys + size)) + && (caddr >= (unsigned )pb->ch1_cmd_phys); +} +static void overlay_start (struct planb *pb) {
@@ -852,16 +862,6 @@#define PLANB_PALETTE_MAX 15 -static inline int overlay_is_active (struct planb *pb) -{ -unsigned int size = pb->tab_size *sizeof (struct dbdma_cmd ); -unsigned int caddr = (unsigned )in_le32 (&pb->planb_base->ch1.cmdptr); - -return (in_le32 (&pb->overlay_last1->cmd_dep) == pb->ch1_cmd_phys) - && (caddr < (pb->ch1_cmd_phys + size)) - && (caddr >= (unsigned )pb->ch1_cmd_phys); -} -static int vgrab (struct planb *pb,struct video_mmap *mp) {unsigned int fr = mp->frame;
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Quoted 6 lines · Tom Rini
[ aside: This has been sitting in the linuxppc-2.5 bk tree for I don't
know how long. And the driver is still horribly broken. ]The following patch moves
overlay_is_activeto before its first use. It was originally written when gcc wouldn't complain, but now does, about not having the definition before usage.
Oops,
Signed-off-by Tom Rini <[email protected]>
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/