remove hil_kbd.c?
Helge, et al,
I was wondering why we have two hil keyboard files:
drivers/input/keyboard/hil_kbd.c drivers/input/keyboard/hilkbd.c
The header comments suggest Helge is maintaining hilkbd.c and we should delete the other:
==> hil_kbd.c <==
/*
* Generic linux-input device driver for keyboard devices *
* Copyright (c) 2001 Brian S. Julin
* All rights reserved.
...
Is that correct?
thanks,
grant
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
Quoted 15 lines · Grant Grundler
Helge, et al,
I was wondering why we have two hil keyboard files:
drivers/input/keyboard/hil_kbd.cdrivers/input/keyboard/hilkbd.cThe header comments suggest Helge is maintaining
hilkbd.cand we should delete the other:
==>hil_kbd.c<==
/*
* Generic linux-input device driver for keyboard devices *
* Copyright (c) 2001 Brian S. Julin
* All rights reserved.
...
Quoted 1 line
Is that correct?
Just the opposite way round. hilkbd.c is the one I ported from the m68k guys back in 1999. hil_kbd.c is the shiny new input-layer one that Brian Julin wrote from scratch. Check the Kconfig/Makefile.
Signature · 10 lines
"Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain _______________________________________________ parisc-linux mailing list [email protected] http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
Quoted 3 lines · Matthew Wilcox
Just the opposite way round.
hilkbd.cis the one I ported from the m68k guys back in 1999.hil_kbd.cis the shiny new input-layer one that Brian Julin wrote from scratch. Check the Kconfig/Makefile.
I forgot to say that it is, of course, desirable that we eliminate the earlier driver. It doesn't support HIL mice or other HIL devices. I'd really like to see some of the problems with the newer driver fixed though:
- Apparent consumption of 70%+ CPU
- Booting without a HIL device attached leads to hundreds of messages about requests already being queued.
Signature · 10 lines
"Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain _______________________________________________ parisc-linux mailing list [email protected] http://lists.parisc-linux.org/mailman/listinfo/parisc-linux