Skip to contentSkip to conversation

ppc32: Update 8260_io/fcc_enet.c to function again

PATCH Bastos Fernandez Alexandre 2 participants 2 messages Mar 16, 2005

lore
Share & tools
lore
#0 lore raw

What can we do?
Has Oray's patch been commited? Or not yet?

I suggest commiting all the changes in this driver from linuxppc tree to linux tree
and after this ask Oray to test again the driver and submmit new patch. Or ask Oray to submmit changes patch to linuxppc

Best regards,

Alex

Quoted 39 lines

-----Original Message-----
From: Andrew Morton [SMTP:[email protected]]
Sent: Wednesday, March 16, 2005 7:32 AM
To: Tom Rini
Cc: [email protected]; Leo Li; Alexandre Bastos; Balasaygun,
Oray (Oray)
Subject: Re: [PATCH] ppc32: Update 8260_io/fcc_enet.c to function
again

Quoted 17 lines · Tom Rini

There's too many things in here that've sat too long (I'd been hoping to
just delete the driver, but that hasn't happened yet, so). A cobbled together list of changes is:

- Update MDIO support for workqueues.
- Make use of <linux/mii.h>
- Add RPX6 support.
- Comment out set_multicast_list (broken).
- Rework tx_ring stuff so we have tx_free, not tx_Full/n_pkts.
- Other PHY updates/fixes.
- Leo Li: Rework FCC clock configuration, make it easier.
- 2.4 : VLAN header room, other misc bits.
- Kill MII_REG_NNN in favor of defines from <linux/mii.h>
- DM9161 PHY support (2.4, Myself & [email protected])
- PQ2ADS and PQ2FADS support bits (Myself & [email protected]

Quoted 3 lines

From: Leo Li <[email protected]>

That's unfortunate - Oray sent a patch in just a few days ago which also fixes up this driver. See

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.1 1-mm3/broken-out/ppc-8260-fcc-ethernet-driver-cannot-read-lxt971-phy-id.pa tch

What should we do?

#1 lore raw
Quoted 7 lines · Bastos Fernandez Alexandre

What can we do?
Has Oray's patch been commited? Or not yet?

I suggest commiting all the changes in this driver from linuxppc tree to linux tree
and after this ask Oray to test again the driver and submmit new patch. Or ask Oray to submmit changes patch to linuxppc

So, Oray's patch has two things in it, it looks like. The basic re-porting to 2.6 APIs, and support for the EON8260. The EON8260 changes should be a bit cleaner to redo after the patch I sent goes in as some of the other cleanups will help there. But I'd also like to see the full EON8260 changes :) The 2.6 API parts look close, but I went and expanded a good bit more on them.

I'd like to drop Oray's patch for now, and have the EON8260 work be resubmitted to lkml/[email protected].

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/