acpi: right error level for fan failures
Subsystems (2)
Hi!
This prints messages on fan failures in KERN_ERR level (so that user actually has chance to see them). It also does not retry all the time. On evo560c, fan failures do happen, and trying again in a loop only makes things worse. Please apply,
Pavel
Signed-off-by Pavel Machek <[email protected]>
drivers/acpi/thermal.c +2 -4
@@ -612,8 +625,7 @@for (j =0 ; j < active->devices.count; j++) { result =acpi_bus_set_power (active->devices.handles[j],ACPI_STATE_D0 );if (result) { -ACPI_DEBUG_PRINT ((ACPI_DB_WARN ,"Unable to turn cooling device [%p] 'on'\n" , active->devices.handles[j])); -continue ; +printk (KERN_ERR "Unable to turn cooling device [%p] 'on'\n" , active->devices.handles[j]); } active->flags.enabled =1 ;ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Cooling device [%p] now 'on'\n" , active->devices.handles[j]));
@@ -630,8 +642,7 @@for (j =0 ; j < active->devices.count; j++) { result =acpi_bus_set_power (active->devices.handles[j],ACPI_STATE_D3 );if (result) { -ACPI_DEBUG_PRINT ((ACPI_DB_WARN ,"Unable to turn cooling device [%p] 'off'\n" , active->devices.handles[j])); -continue ; +printk (KERN_ERR "Unable to turn cooling device [%p] 'off'\n" , active->devices.handles[j]); } active->flags.enabled =0 ;ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Cooling device [%p] now 'off'\n" , active->devices.handles[j]));
Signature · 9 lines
People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click