Skip to contentSkip to conversation

del_timer_sync scalability patch

PATCH Chen, Kenneth W 3 participants 6 messages Mar 20, 2005 – Mar 21, 2005

lore
Share & tools
lore
#1 lore raw
Quoted 4 lines · Kenneth W

We did exactly the same thing about 10 months back. Nice to see that independent people came up with exactly the same solution that we proposed 10 months back.

Well the same question applies. Christoph, which code is calling del_timer_sync() so often that you noticed?

Quoted 2 lines

In fact, this patch
is line-by-line identical to the one we post.

I assume that's not a coincidence.

Quoted 1 line

Hope Andrew is going to take the patch this time.

Hope Kenneth is going to test the alternate del_timer_sync patches in next -mm ;)

#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 4 lines · Kenneth W

We did exactly the same thing about 10 months back. Nice to see that independent people came up with exactly the same solution that we proposed 10 months back.

Well the same question applies. Christoph, which code is calling del_timer_sync() so often that you noticed?

Ummm. I have to ask those who brought this to my attention. Are you looking for the application under which del_timer_sync showed up in profiling or the kernel subsystem?

#3 lore raw
Quoted 9 lines · Christoph Lameter
Quoted 6 lines · Andrew Morton
Quoted 4 lines · Kenneth W

We did exactly the same thing about 10 months back. Nice to see that independent people came up with exactly the same solution that we proposed 10 months back.

Quoted 6 lines
Quoted 2 lines

Well the same question applies. Christoph, which code is calling del_timer_sync() so often that you noticed?

Ummm. I have to ask those who brought this to my attention. Are you looking for the application under which del_timer_sync showed up in profiling or the kernel subsystem?

I was wondering which part of the kernel was hammering del_timer_sync() so hard. I guess we could work that out from a description of the workload.

#4 lore raw
In reply to Andrew Morton
Quoted 4 lines · Andrew Morton
Quoted 1 line

Hope Andrew is going to take the patch this time.

Hope Kenneth is going to test the alternate del_timer_sync patches in next -mm ;)

BTW Why are we going through this? Oleg has posted a much better solution to this issue yersteday AFAIK.

#5 lore raw
Quoted 10 lines · Christoph Lameter
Quoted 4 lines · Andrew Morton
Quoted 1 line

Hope Andrew is going to take the patch this time.

Hope Kenneth is going to test the alternate del_timer_sync patches in next -mm ;)

BTW Why are we going through this? Oleg has posted a much better solution to this issue yersteday AFAIK.

That is what I was referring to.

Those patches need to be reviewed, performance tested and stability tested. It's appropriate that interested parties do that work, please.