GDB error return codes

PATCH New Paul Brook 1 participant 1 message Mar 20, 2005

lore

Share & tools

lore

Paul Brook

author

2005-03-20 19:16 UTC #0 lore raw

PATCH 1/1 GDB error return codes

The gdb remote protocol uses the response "ENN" to report an error, where NN is an errno code, not a literal string.

Patch below fixes this.

Paul

Index: gdbstub.c
===================================================================
RCS file: /cvsroot/qemu/qemu/gdbstub.c,v
retrieving revision 1.23

gdbstub.c 20 Mar 2005 18:39:09 -0000 renamed from gdbstub.c 17 Jan 2005 22:03:16 -0000 1.23 +2 -2

diff -u -p -r1.23 gdbstub.c
@@ -424,7 +479,7 @@ static int gdb_handle_packet(GDBState *s
             p++;
         hextomem(mem_buf, p, len);
         if (cpu_memory_rw_debug(env, addr, mem_buf, len, 1) != 0)
-            put_packet(s, "ENN");
+            put_packet(s, "E14");
         else
             put_packet(s, "OK");
         break;

@@ -442,7 +497,7 @@ static int gdb_handle_packet(GDBState *s
             put_packet(s, "OK");
         } else {
         breakpoint_error:
-            put_packet(s, "ENN");
+            put_packet(s, "E22");
         }
         break;
     case 'z':