Skip to contentSkip to conversation

2.6.12-rc1, ./drivers/base/platform.c

PATCH In review All Linux 3 participants 4 messages Mar 22, 2005 Driver core

lore
Share & tools
lore

All Linux

author
#0 lore raw

PATCH 1/1 2.6.12-rc1, ./drivers/base/platform.c

The latest prepatch, 2.6.12-rc1, introduced the following change.

drivers/base/platform.c 2005-03-17 17:35:04 -08:00 +0 -1
@@ -131,7 +131,7 @@
         pdev->dev.bus = &platform_bus_type;
 
         if (pdev->id != -1)
-                snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s%u",

pdev->name, pdev->id);
+ snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s.%u",

pdev->name, pdev->id);
         else
                 strlcpy(pdev->dev.bus_id, pdev->name, BUS_ID_SIZE);

It causes problem, as most platform files, for example, arch/ppc/platforms/katana.c, still use the old name without ".". I do not understand why bus_id "mpsc.0" is better than "mpsc0". Please explain what is the benefit of introducing such a change, before I can submit a patch for all those platform files to work with this change.
Please CC me, as I am currently not in the list.

Thanks,

Lee

#1 lore raw
Quoted 15 lines · All Linux

The latest prepatch, 2.6.12-rc1, introduced the following change.

drivers/base/platform.c 2005-03-17 17:35:04 -08:00 +1 -1
@@ -131,7 +131,7 @@
         pdev->dev.bus = &platform_bus_type;
 
         if (pdev->id != -1)
-                snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s%u",
 pdev->name, pdev->id);
+                snprintf(pdev->dev.bus_id, BUS_ID_SIZE, "%s.%u",
 pdev->name, pdev->id);
         else
                 strlcpy(pdev->dev.bus_id, pdev->name, BUS_ID_SIZE);
Quoted 8 lines

It causes problem, as most platform files, for example, arch/ppc/platforms/katana.c, still use the old name without ".". I do not understand why bus_id "mpsc.0" is better than "mpsc0". Please explain what is the benefit of introducing such a change, before I can submit a patch for all those platform files to work with this change.
Please CC me, as I am currently not in the list.

Devices/drivers ending with a digit, such as i8250, produce "wierd" names - i82500, i82501, etc.

Signature · 1 line
Dmitry
#2 lore raw
In reply to All Linux
Quoted 2 lines · All Linux

It causes problem, as most platform files, for example, arch/ppc/platforms/katana.c, still use the old name without ".". I do

Mark Greer recently produced a patch for the katana board among other PPC platforms to fix this breakage. I'll look for the announcement mail but I recall seeing it a day or two ago.

Thanks
Brian

author
#3 lore raw
Quoted 11 lines · Brian Waite
Quoted 2 lines · All Linux

It causes problem, as most platform files, for example, arch/ppc/platforms/katana.c, still use the old name without ".". I do

Mark Greer recently produced a patch for the katana board among other PPC platforms to fix this breakage. I'll look for the announcement mail but I recall seeing it a day or two ago.

Thanks
Brian

Ok, I will wait for Mark Greer's patch. Thanks.