drivers/net/eql.c: kill dead code

PATCH Applied Adrian Bunk 3 participants 4 messages Mar 22, 2005 – Mar 23, 2005 Network drivers

lore

Share & tools

lore

Adrian Bunk

author

2005-03-22 21:59 UTC #0 lore raw

PATCH 1/1 drivers/net/eql.c: kill dead code

This patch removes some obviously dead code found by the Coverity checker.

Signed-off-by Adrian Bunk <[email protected]>

drivers/net/eql.c renamed from drivers/net/eql.c.old +0 -4

@@ -498,10 +498,8 @@
 	if (!slave_dev)
 		return -ENODEV;
 
 	ret = -EINVAL;
-	if (!slave_dev)
-		return ret;
 
 	spin_lock_bh(&eql->queue.lock);
 	if (eql_is_slave(slave_dev)) {
 		slave = __eql_find_slave_dev(&eql->queue, slave_dev);

@@ -535,10 +533,8 @@
 	if (!slave_dev)
 		return -ENODEV;
 
 	ret = -EINVAL;
-	if (!slave_dev)
-		return ret;
 
 	eql = netdev_priv(dev);
 	spin_lock_bh(&eql->queue.lock);
 	if (eql_is_slave(slave_dev)) {

David S. Miller

maintainer Applied

2005-03-23 20:28 UTC #1 lore raw

Quoted 4 lines · On Tue, 22 Mar 2005 22:53:54 +0100 Adrian Bunk <[email protected]> wrote:

This patch removes some obviously dead code found by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>

Applied, thanks Adrian.

Jeff Garzik

2005-03-23 20:32 UTC #2 lore raw

Quoted 9 lines · David S. Miller

Quoted 4 lines · On Tue, 22 Mar 2005 22:53:54 +0100 Adrian Bunk <[email protected]> wrote:
This patch removes some obviously dead code found by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
Applied, thanks Adrian.

Note that I apply drivers/net/* stuff too, including this one... :)

http://marc.theaimsgroup.com/?l=linux-kernel&m=111154928104675&w=2

Jeff

David S. Miller

maintainer

2005-03-23 21:10 UTC #3 lore raw

Quoted 1 line · On Wed, 23 Mar 2005 15:28:23 -0500 Jeff Garzik <[email protected]> wrote:

Note that I apply drivers/net/* stuff too, including this one... :)

I realized this was a possibility, BK will figure it out once it gets merged so no worries.

Generally, besides bonding, I pretty much take the changes in for non-hardware drivers like eql, shaper, and friends.