net/slip: replace schedule_timeout() with msleep()

Use msleep() instead of schedule_timeout() to guarantee
the task delays as expected. While the original code does use TASK_INTERRUPTIBLE, it does not check for signals, so I believe msleep() is more appropriate.

Signed-off-by Nishanth Aravamudan <[email protected]>

Signed-off-by Domen Puncer <[email protected]>

---

 kj-domen/drivers/net/slip.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff -puN drivers/net/slip.c~msleep-drivers_net_slip drivers/net/slip.c

drivers/net/slip.c renamed from drivers/net/slip.c~msleep-drivers_net_slip +1 -0

@@ -75,6 +75,7 @@
 #include <linux/if_arp.h>
 #include <linux/if_slip.h>
 #include <linux/init.h>
+#include <linux/delay.h>
 #include "slip.h"
 #ifdef CONFIG_INET
 #include <linux/ip.h>

Quoted 30 lines · [email protected] wrote:

Use msleep() instead of schedule_timeout() to guarantee
the task delays as expected. While the original code does use TASK_INTERRUPTIBLE, it does not check for signals, so I believe msleep() is more
appropriate.

Signed-off-by Nishanth Aravamudan <[email protected]>

Signed-off-by Domen Puncer <[email protected]>

---

kj-domen/drivers/net/slip.c | 7 +++----

1 files changed, 3 insertions(+), 4 deletions(-)

diff -puN drivers/net/slip.c~msleep-drivers_net_slip drivers/net/slip.c
--- kj/drivers/net/slip.c~msleep-drivers_net_slip 2005-03-05
16:10:49.000000000 +0100
+++ kj-domen/drivers/net/slip.c 2005-03-05 16:10:49.000000000 +0100

drivers/net/slip.c renamed from drivers/net/slip.c~msleep-drivers_net_slip +1 -0

@@ -75,6 +75,7 @@
 #include <linux/if_arp.h>
 #include <linux/if_slip.h>
 #include <linux/init.h>
+#include <linux/delay.h>
 #include "slip.h"
 #ifdef CONFIG_INET
 #include <linux/ip.h>

@@ -1395,10 +1396,8 @@ static void __exit slip_exit(void)
 	/* First of all: check for active disciplines and hangup them.
 	 */
 	do {

drivers/net/slip.c static void __exit slip_exit(void) · line 1400

Quoted 6 lines

drivers/net/slip.c renamed from drivers/net/slip.c~msleep-drivers_net_slip +2 -4

-		if (busy) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(HZ / 10);
-		}
+		if (busy)
+			msleep(100);

msleep_interruptible