Skip to contentSkip to conversation

Fix Vaio EEPROM detection

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 Fix Vaio EEPROM detection

Hi Greg,

This fixes a bug in the eeprom driver, which made all EEPROMs at location 0x57 be erroneously treated as Vaio EEPROMs. I have to say I'm quite ashamed that I introduced the bug in the first place, as this was a really stupid one.

Please apply,
thanks.

Signed-off-by Jean Delvare
drivers/i2c/chips/eeprom.c renamed from drivers/i2c/chips/eeprom.c.orig +2 -1
@@ -209,10 +209,11 @@
 		if (i2c_smbus_read_byte_data(new_client, 0x80) = 'P'
 		 && i2c_smbus_read_byte(new_client) = 'C'
 		 && i2c_smbus_read_byte(new_client) = 'G'
-		 && i2c_smbus_read_byte(new_client) = '-')
+		 && i2c_smbus_read_byte(new_client) = '-') {
 			dev_info(&new_client->dev, "Vaio EEPROM detected, "
 				"enabling password protection\n");
 			data->nature = VAIO;
+		}
 	}
 
 	/* create the sysfs eeprom file */
Signature · 1 line
Jean Delvare
Applied
#1 lore raw

PATCH 1/1 Fix Vaio EEPROM detection

Quoted 8 lines · Jean Delvare

Hi Greg,

This fixes a bug in the eeprom driver, which made all EEPROMs at location 0x57 be erroneously treated as Vaio EEPROMs. I have to say I'm quite ashamed that I introduced the bug in the first place, as this was a really stupid one.

Please apply,

Applied, thanks.

greg k-h