drivers/usb/core/devices.c: small corrections
PATCH 1/1 drivers/usb/core/devices.c: small corrections
total_written is used at places where it can't have any value different from 0.
This patch is partially based on findings of the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
drivers/usb/core/devices.c renamed from drivers/usb/core/devices.c.old +2 -5
@@ -460,7 +460,7 @@ static ssize_t usb_device_dump(char __usreturn 0 ;if (level >MAX_TOPO_LEVEL ) -return total_written; +return 0 ;/* allocate 2^1 pages = 8K (on i386); should be more than enough for one device */ if (!(pages_start = (char *)__get_free_pages (GFP_KERNEL ,1 )))return -ENOMEM ;
@@ -527,10 +527,7 @@ static ssize_t usb_device_dump(char __us length = *nbytes;if (copy_to_user (*buffer, pages_start + *skip_bytes, length)) {free_pages ((unsigned long )pages_start,1 ); - -if (total_written ==0 ) -return -EFAULT ; -return total_written; +return -EFAULT ; } *nbytes -= length; *file_offset += length;
Greg KH
AppliedQuoted 6 lines · Adrian Bunk
total_writtenis used at places where it can't have any value different from 0.This patch is partially based on findings of the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
Applied, thanks.
greg k-h