Skip to contentSkip to conversation

drivers/char/ipmi/ipmi_msghandler.c: fix an off by one error

PATCH New Adrian Bunk 1 participant 1 message Mar 25, 2005 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/ipmi/ipmi_msghandler.c: fix an off by one error

This patch fixes an off by one error found by the Coverity checker (ipmi_interfaces contains MAX_IPMI_INTERFACES elements).

drivers/char/ipmi/ipmi_msghandler.c renamed from drivers/char/ipmi/ipmi_msghandler.c.old +1 -1
@@ -641,7 +641,7 @@ int ipmi_create_user(unsigned int       
 		return -ENOMEM;
 
 	down_read(&interfaces_sem);
-	if ((if_num > MAX_IPMI_INTERFACES) || ipmi_interfaces[if_num] == NULL)
+	if ((if_num >= MAX_IPMI_INTERFACES) || ipmi_interfaces[if_num] == NULL)
 	{
 		rv = -EINVAL;
 		goto out_unlock;