Skip to contentSkip to conversation

Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library

DISCUSSION Marcelo Tosatti 1 participant 1 message Mar 26, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 12 lines · Andreas Arens

Hi Marcelo, Herbert,

I'm just reading the patch so don't know of any hidden side-effects which might cure it, but this clearly looks like a possibly deadlocking typo in fs/binfmt_elf.c to me:

Review

Quoted 4 lines
(quoted diff) +2 -1
-       while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
+       while (elf_phdata->p_type != PT_LOAD)
+               eppnt++;

Shouldn't this be:

Review

Quoted 3 lines
(quoted diff) +2 -1
-       while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
+       while (eppnt->p_type != PT_LOAD)
+               eppnt++;

Doh.

Yes, it is. I change it accordingly, will release another -rc :(