Skip to contentSkip to conversation

shrink drivers/pci/proc.c::pci_seq_start()

PATCH Applied Rolf Eike Beer 2 participants 2 messages Mar 27, 2005 – Mar 28, 2005 PCI

lore
Share & tools
lore

Rolf Eike Beer

author
#0 lore raw

PATCH 1/1 shrink drivers/pci/proc.c::pci_seq_start()

Hi,

this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead of explicitely using a loop and avoiding a goto.

Eike

Signed-off-by Rolf Eike Beer <[email protected]>
drivers/pci/proc.c +3 -6
@@ -313,13 +313,10 @@ static void *pci_seq_start(struct seq_fi
 	struct pci_dev *dev = NULL;
 	loff_t n = *pos;
 
-	dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
-	while (n--) {
-		dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
-		if (dev == NULL)
-			goto exit;
+	for_each_pci_dev(dev) {
+		if (!n--)
+			break;
 	}
-exit:
 	return dev;
 }
Applied
#1 lore raw
Quoted 8 lines · Rolf Eike Beer

Hi,

this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead of explicitely using a loop and avoiding a goto.

Eike

Signed-off-by Rolf Eike Beer <[email protected]>

Applied, thanks.

greg k-h