Skip to contentSkip to conversation

sound/oss/sonicvibes.c: fix an array overflow

PATCH New Adrian Bunk 1 participant 1 message Mar 27, 2005 Sound

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 sound/oss/sonicvibes.c: fix an array overflow

This patch fixes an array overflow found by the Coverity checker.

Signed-off-by Adrian Bunk <[email protected]>
sound/oss/sonicvibes.c renamed from sound/oss/sonicvibes.c.old +1 -1
@@ -1146,13 +1146,13 @@ static int mixer_ioctl(struct sv_state *
 		for (i = 0; i < SOUND_MIXER_NRDEVICES; i++) {
 			if (!(val & (1 << i)))
 				continue;
 			if (mixtable[i].rec)
 				break;
 		}
-		if (!mixtable[i].rec)
+		if (i == SOUND_MIXER_NRDEVICES)
 			return 0;
 		spin_lock_irqsave(&s->lock, flags);
 		frobindir(s, SV_CIMIX_ADCINL, 0x1f, mixtable[i].rec << 5);
 		frobindir(s, SV_CIMIX_ADCINR, 0x1f, mixtable[i].rec << 5);
 		spin_unlock_irqrestore(&s->lock, flags);
 		return 0;