typo fix in Documentation/eisa.txt
PATCH 1/1 typo fix in Documentation/eisa.txt
Trivial typo fix.
Documentation/eisa.txt +1 -1
@@ -171,7 +171,7 @@ virtual_root.force_probe : Force the probing code to probe EISA slots even when it cannot find an -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force), and set to 1 (force probing) when either CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set.
Hi Eike,
Documentation/eisa.txt line 176
Quoted 7 lines
Trivial typo fix.
(...)
Force the probing code to probe EISA slots even when it cannot find anDocumentation/eisa.txt +1
-1-EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force), and set to 1 (force probing) when either CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set.
Wouldn't it rather be "Defaults"?
Signature · 1 line
Jean Delvare
Quoted 11 lines · Jean Delvare
Hi Eike,
Documentation/eisa.txt line 176
Quoted 7 lines
Trivial typo fix.
(...)
Force the probing code to probe EISA slots even when it cannot find anDocumentation/eisa.txt +1
-1-EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force), and set to 1 (force probing) when either CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set.Wouldn't it rather be "Defaults"?
Damn, yes. Every time I read it again I feel a little bit more comfortable with s/are set/is set/. Am I right or is it already too late for useful work?
Eike
Quoted 16 lines · Rolf Eike Beer
Quoted 12 lines · Jean Delvare
Hi Eike,
Quoted 7 lines
Trivial typo fix.
(...)
Force the probing code to probe EISA slots even when it cannot find anDocumentation/eisa.txt +1
-1-EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0(don't force), and set to 1 (force probing) when either
CONFIG_ALPHA_JENSENorCONFIG_EISA_VLB_PRIMINGare set.Wouldn't it rather be "Defaults"?
Quoted 1 line
Damn, yes. Every time I read it again I feel a little bit more comfortable with s/are set/is set/. Am I right or is it already too late for useful work?
Defaults
when either FOO or BAR is set.
and the comma after (don't force) shouldn't be there...
Signature · 1 line
~Randy
Typo fixes.
Thanks to Randy Dunlap and Jean Delvare.
Documentation/eisa.txt +3 -3
@@ -171,9 +171,9 @@ virtual_root.force_probe : Force the probing code to probe EISA slots even when it cannot find an -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 -(don't force), and set to 1 (force probing) when either -CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set. +EISA compliant mainboard (nothing appears on slot 0). Defaults to 0 +(don't force) and set to 1 (force probing) when either +CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING is set. ** Random notes :
Quoted 13 lines · Rolf Eike Beer
Typo fixes.
Thanks to Randy Dunlap and Jean Delvare.
Signed-off-by Rolf Eike Beer <[email protected]>Documentation/eisa.txt +0
-0@@ -171,9 +171,9 @@virtual_root.force_probe :
Force the probing code to probe EISA slots even when it cannot find an
Documentation/eisa.txt line 176
Quoted 6 lines
Documentation/eisa.txt +3
-3-EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 -(don't force), and set to 1 (force probing) when either -CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set. +EISA compliant mainboard (nothing appears on slot 0). Defaults to 0 +(don't force) and set to 1 (force probing) when either +CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING is set.
---
01234567890123456789012345678901234567890123456789012345678901234567890123456789
My expertise is limited by a fuzzy memory, and I know it's bad form to
comment much on english usage or spelling as they are often tangential to the issue at hand, but as long as we are on the topic, I think you had it right the first time.
I believe the comment, properly used the "imperative":
declaring intended usage of the variable, i.e. - "Do this or do that"; "Default to 0 or set to 1". To use a perl like example:
# set probe action: probe=0; # default to 0 (don't force) probe=1 if (X || Y); # and set to 1 (force), if either X or Y is set
If you use "Defaults", then I think that's an implied 3rd person
singular usage and for correct parallelism, the parallel clause (after the "and") should use the same tense. Third person tense for "set" would use "is" as a passive-voice auxiliary: "[it] is set to 1..."
Saying "default to 0" is like the perlism:
setup values of v:
v=0; # default to 0
v=1 if (X || Y); # and set to 1 if X or Y is set
I can't believe we are discussing grammer concerns in comments in
the linux-kenel. :-) (!).
-linda
Quoted 11 lines
Quoted 7 lines
Documentation/eisa.txt line 176
Quoted 5 lines
Force the probing code to probe EISA slots even when it cannot find an
Documentation/eisa.txt +1
-1-EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force), and set to 1 (force probing) when either CONFIG_ALPHA_JENSEN or CONFIG_EISA_VLB_PRIMING are set.Wouldn't it rather be "Defaults"?
Damn, yes. Every time I read it again I feel a little bit more comfortable with s/are set/is set/. Am I right or is it already too late for useful work?
"is" is better, even if both are commonly used in this case. And no, it's not to late.
Signature · 1 line
Jean Delvare