Skip to contentSkip to conversation

2.6.12-rc1-mm3

DISCUSSION Reuben Farrelly 4 participants 7 messages Mar 28, 2005 – May 26, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

Quoted 4 lines · Andrew Morton

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm3/

- Mainly a bunch of fixes relative to 2.6.12-rc1-mm2.

Quoted 8 lines

- Again, we'd like people who have had recent DRM and USB resume problems to test and report, please.

- The bk-ide-dev tree is back after a couple of weeks of difficulties.

- Jeff asks that anyone who has had problems with the Silicon Image SATA drivers test sata_sil-corruption--lockup-fix.patch, which is included in this kernel.

I'm repeatably getting this crash on shutdown in -mm3, and a few releases earlier (but I can't be certain it was the same crash..)

Serial: 8250/16550 driver $Revision: 1.90 $ 8 ports, IRQ sharing enabled ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
ttyS4 at I/O 0xa400 (irq = 16) is a 16550A
ttyS5 at I/O 0xa408 (irq = 16) is a 16550A

This _may_ be the culprit, but I'm not sure:

03:03.0 Serial controller: Timedia Technology Co Ltd PCI2S550 (Dual 16550 UART) (rev 01) (prog-if 02 [16550])
Subsystem: Timedia Technology Co Ltd: Unknown device 0002
Flags: stepping, medium devsel, IRQ 16
I/O ports at a400 [size=32]

The board is an Intel D925XCV.

Shutdown goes like this: (yes, hyperterminal sucks for the ^M characters, sorry)

INIT: Switching^MINIT: Sending processes the TERM signal Stopping yum: Disabling nightly yum update: [ OK ] [ OK ]
Stopping cups-config-daemon: [ OK ]
Stopping HAL daemon: [ OK ]
Stopping system message bus: [ OK ]
Stopping atd: [ OK ]
Stopping cups: [ OK ]
Shutting down xfs: [ OK ]
Shutting down console mouse services: [ OK ]

Unable to handle kernel paging request at virtual address f3a6ce68
 printing eip:
c0244109
*pde = 00000000
Oops: 0000 [#1]
SMP DEBUG_PAGEALLOC
Modules linked in: hidp hci_usb sermouse nfsd exportfs md5 ipv6 lp autofs4 eeprom lm85 i2c_sensor rfcomm l2cap bluetooth nfs lock
d sunrpc usb_storage pwc videodev dm_mod video button battery ac ohci1394 ieee1394 uhci_hcd ehci_hcd parport_serial parport_pc parp
ort hw_random i2c_i801 i2c_core emu10k1_gp gameport e100 mii floppy ext3 jbd ata_piix libata sd_mod scsi_mod
CPU:    0
EIP:    0060:[<c0244109>]    Not tainted VLI
EFLAGS: 00010286   (2.6.12-rc1-mm3)

EIP is at serport_ldisc_write_wakeup+0x9/0x20
eax: f3a6cdf8 ebx: f73d7000 ecx: c038e374 edx: c0244100
esi: f73d700c edi: f73d7000 ebp: c049e900 esp: f7568dc0
ds: 007b es: 007b ss: 0068
Process inputattach (pid: 2932, threadinfo=f7568000 task=f6993ac0)

Stack: c021bb08 00000286 f6c31000 c0245e4a f6c31018 f73d7000 f67c1e88 cbff5c
       00000000 c021ceaa 00000000 00000000 00000000 c1e46000 c1e46000 
00000000
       00000000 c011b739 00000046 c1e46000 00000001 f2c00000 f2c00000 
c011b8b4
Call Trace:
^M [<c021bb08>] tty_wakeup+0x48/0x70
^M [<c0245e4a>] uart_close+0xca/0x1e0
^M [<c021ceaa>] release_dev+0x14a/0x750
^M [<c011b739>] change_page_attr+0x29/0x60
^M [<c011b8b4>] kernel_map_pages+0x84/0xa0
^M [<c014cbca>] store_stackinfo+0x5a/0x90
^M [<c01664c8>] __fput+0x108/0x180
^M [<c018b59b>] inotify_inode_queue_event+0x2b/0x40
^M [<c021d97f>] tty_release+0xf/0x20
^M [<c016644a>] __fput+0x8a/0x180
^M [<c0164d7b>] filp_close+0x4b/0x70
^M [<c0125254>] put_files_struct+0x74/0x100
^M [<c012610c>] do_exit+0x11c/0x420
^M [<c012647d>] do_group_exit+0x2d/0xa0
^M [<c012f74c>] get_signal_to_deliver+0x20c/0x310
^M [<c0103deb>] do_signal+0x5b/0x140
^M [<c011ea89>] __wake_up+0x29/0x40
^M [<c021b60c>] tty_ldisc_deref+0x3c/0x70
^M [<c021c267>] tty_read+0xc7/0x130
^M [<c0243fb0>] serport_ldisc_read+0x0/0x100
^M [<c016ecd3>] sys_fstat64+0x23/0x30
^M [<c021c1a0>] tty_read+0x0/0x130
^M [<c0165547>] vfs_read+0x97/0x140
^M [<c016585c>] sys_read+0x3c/0x70
^M [<c0103efa>] do_notify_resume+0x2a/0x40
^M [<c01040be>] work_notifysig+0x13/0x25

^MCode: e8 0f b6 c5 88 4b 4b 31 d2 c1 e9 10 88 43 4a 88 4b 49 89 d0 5b c3 8d b6 00 00 00 00 8d bf 00 00 00 00 8b 80 a8 09 00 00 8b 40 14 <8b> 50 70 85 d2 74 09 8b 52 10 85 d2 74 02 ff d2 c3 90 90 90 90
^M BUG: atomic counter underflow at:
^M [<c0126386>] do_exit+0x396/0x420
^M [<c01059f6>] die+0x166/0x170
^M [<c011a7a3>] do_page_fault+0x1f3/0x6a1
^M [<c0244109>] serport_ldisc_write_wakeup+0x9/0x20
^M [<c011b36c>] __change_page_attr+0x4c/0x3f0
^M [<c011a5b0>] do_page_fault+0x0/0x6a1
^M [<c010522f>] error_code+0x4f/0x60
^M [<c0244100>] serport_ldisc_write_wakeup+0x0/0x20
^M [<c0244109>] serport_ldisc_write_wakeup+0x9/0x20
^M [<c021bb08>] tty_wakeup+0x48/0x70
^M [<c0245e4a>] uart_close+0xca/0x1e0
^M [<c021ceaa>] release_dev+0x14a/0x750
^M [<c011b739>] change_page_attr+0x29/0x60
^M [<c011b8b4>] kernel_map_pages+0x84/0xa0
^M [<c014cbca>] store_stackinfo+0x5a/0x90
^M [<c01664c8>] __fput+0x108/0x180
^M [<c018b59b>] inotify_inode_queue_event+0x2b/0x40
^M [<c021d97f>] tty_release+0xf/0x20
^M [<c016644a>] __fput+0x8a/0x180
^M [<c0164d7b>] filp_close+0x4b/0x70
^M [<c0125254>] put_files_struct+0x74/0x100
^M [<c012610c>] do_exit+0x11c/0x420
^M [<c012647d>] do_group_exit+0x2d/0xa0
^M [<c012f74c>] get_signal_to_deliver+0x20c/0x310
^M [<c0103deb>] do_signal+0x5b/0x140
^M [<c011ea89>] __wake_up+0x29/0x40
^M [<c021b60c>] tty_ldisc_deref+0x3c/0x70
^M [<c021c267>] tty_read+0xc7/0x130
^M [<c0243fb0>] serport_ldisc_read+0x0/0x100
^M [<c016ecd3>] sys_fstat64+0x23/0x30
^M [<c021c1a0>] tty_read+0x0/0x130
^M [<c0165547>] vfs_read+0x97/0x140
^M [<c016585c>] sys_read+0x3c/0x70
^M [<c0103efa>] do_notify_resume+0x2a/0x40
^M [<c01040be>] work_notifysig+0x13/0x25
^MUnable to handle kernel NULL pointer dereference at virtual address 00000020
^M printing eip:
^Mc0121320
^M*pde = 0041f001
^MOops: 0000 [#2]
^MSMP DEBUG_PAGEALLOC

(there's a bit more, which I can put up online if it's helpful)

Reuben

#2 lore raw
Quoted 20 lines · Reuben Farrelly
Unable to handle kernel paging request at virtual address f3a6ce68
  printing eip:
c0244109
*pde = 00000000
Oops: 0000 [#1]
SMP DEBUG_PAGEALLOC
Modules linked in: hidp hci_usb sermouse nfsd exportfs md5 ipv6 lp 

autofs4 eeprom lm85 i2c_sensor rfcomm l2cap bluetooth nfs lock d sunrpc usb_storage pwc videodev dm_mod video button battery ac ohci1394 ieee1394 uhci_hcd ehci_hcd parport_serial parport_pc parp ort hw_random i2c_i801 i2c_core emu10k1_gp gameport e100 mii floppy ext3 jbd ata_piix libata sd_mod scsi_mod

CPU:    0
EIP:    0060:[<c0244109>]    Not tainted VLI
EFLAGS: 00010286   (2.6.12-rc1-mm3)

EIP is at serport_ldisc_write_wakeup+0x9/0x20
eax: f3a6cdf8 ebx: f73d7000 ecx: c038e374 edx: c0244100
esi: f73d700c edi: f73d7000 ebp: c049e900 esp: f7568dc0
ds: 007b es: 007b ss: 0068
Process inputattach (pid: 2932, threadinfo=f7568000 task=f6993ac0)

Quoted 9 lines
Stack: c021bb08 00000286 f6c31000 c0245e4a f6c31018 f73d7000 f67c1e88 
cbff5c
        00000000 c021ceaa 00000000 00000000 00000000 c1e46000 c1e46000 
00000000
        00000000 c011b739 00000046 c1e46000 00000001 f2c00000 f2c00000 
c011b8b4
Call Trace:
^M [<c021bb08>] tty_wakeup+0x48/0x70
^M [<c0245e4a>] uart_close+0xca/0x1e0

Looks like something in the input layer went bang. The code in serport_ldisc_write_wakeup is:

   0:   8b 80 a8 09 00 00       mov    0x9a8(%eax),%eax
   6:   8b 40 14                mov    0x14(%eax),%eax
   9:   8b 50 70                mov    0x70(%eax),%edx <====
   c:   85 d2                   test   %edx,%edx
   e:   74 09                   je     0x19

and the marked line exploded on you. The above instructions correspond with:

0: struct serport *sp = (struct serport *) tty->disc_data;
6: serio_drv_write_wakeup(sp->serio);
9: if (serio->drv

So, "serio" was this strange 0xf3a6cdf8 value. But why? One for the input people I think.

Quoted 63 lines

^M [<c021ceaa>] release_dev+0x14a/0x750
^M [<c011b739>] change_page_attr+0x29/0x60
^M [<c011b8b4>] kernel_map_pages+0x84/0xa0
^M [<c014cbca>] store_stackinfo+0x5a/0x90
^M [<c01664c8>] __fput+0x108/0x180
^M [<c018b59b>] inotify_inode_queue_event+0x2b/0x40
^M [<c021d97f>] tty_release+0xf/0x20
^M [<c016644a>] __fput+0x8a/0x180
^M [<c0164d7b>] filp_close+0x4b/0x70
^M [<c0125254>] put_files_struct+0x74/0x100
^M [<c012610c>] do_exit+0x11c/0x420
^M [<c012647d>] do_group_exit+0x2d/0xa0
^M [<c012f74c>] get_signal_to_deliver+0x20c/0x310
^M [<c0103deb>] do_signal+0x5b/0x140
^M [<c011ea89>] __wake_up+0x29/0x40
^M [<c021b60c>] tty_ldisc_deref+0x3c/0x70
^M [<c021c267>] tty_read+0xc7/0x130
^M [<c0243fb0>] serport_ldisc_read+0x0/0x100
^M [<c016ecd3>] sys_fstat64+0x23/0x30
^M [<c021c1a0>] tty_read+0x0/0x130
^M [<c0165547>] vfs_read+0x97/0x140
^M [<c016585c>] sys_read+0x3c/0x70
^M [<c0103efa>] do_notify_resume+0x2a/0x40
^M [<c01040be>] work_notifysig+0x13/0x25
^MCode: e8 0f b6 c5 88 4b 4b 31 d2 c1 e9 10 88 43 4a 88 4b 49 89 d0 5b c3 8d b6 00 00 00 00 8d bf 00 00 00 00 8b 80 a8 09 00 00 8b 40 14 <8b> 50 70 85 d2 74 09 8b 52 10 85 d2 74 02 ff d2 c3 90 90 90 90 ^M BUG: atomic counter underflow at:
^M [<c0126386>] do_exit+0x396/0x420
^M [<c01059f6>] die+0x166/0x170
^M [<c011a7a3>] do_page_fault+0x1f3/0x6a1
^M [<c0244109>] serport_ldisc_write_wakeup+0x9/0x20
^M [<c011b36c>] __change_page_attr+0x4c/0x3f0
^M [<c011a5b0>] do_page_fault+0x0/0x6a1
^M [<c010522f>] error_code+0x4f/0x60
^M [<c0244100>] serport_ldisc_write_wakeup+0x0/0x20
^M [<c0244109>] serport_ldisc_write_wakeup+0x9/0x20
^M [<c021bb08>] tty_wakeup+0x48/0x70
^M [<c0245e4a>] uart_close+0xca/0x1e0
^M [<c021ceaa>] release_dev+0x14a/0x750
^M [<c011b739>] change_page_attr+0x29/0x60
^M [<c011b8b4>] kernel_map_pages+0x84/0xa0
^M [<c014cbca>] store_stackinfo+0x5a/0x90
^M [<c01664c8>] __fput+0x108/0x180
^M [<c018b59b>] inotify_inode_queue_event+0x2b/0x40
^M [<c021d97f>] tty_release+0xf/0x20
^M [<c016644a>] __fput+0x8a/0x180
^M [<c0164d7b>] filp_close+0x4b/0x70
^M [<c0125254>] put_files_struct+0x74/0x100
^M [<c012610c>] do_exit+0x11c/0x420
^M [<c012647d>] do_group_exit+0x2d/0xa0
^M [<c012f74c>] get_signal_to_deliver+0x20c/0x310
^M [<c0103deb>] do_signal+0x5b/0x140
^M [<c011ea89>] __wake_up+0x29/0x40
^M [<c021b60c>] tty_ldisc_deref+0x3c/0x70
^M [<c021c267>] tty_read+0xc7/0x130
^M [<c0243fb0>] serport_ldisc_read+0x0/0x100
^M [<c016ecd3>] sys_fstat64+0x23/0x30
^M [<c021c1a0>] tty_read+0x0/0x130
^M [<c0165547>] vfs_read+0x97/0x140
^M [<c016585c>] sys_read+0x3c/0x70
^M [<c0103efa>] do_notify_resume+0x2a/0x40
^M [<c01040be>] work_notifysig+0x13/0x25

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#3 lore raw
Quoted 12 lines · Russell King

Looks like something in the input layer went bang.  The code in serport_ldisc_write_wakeup is:

   0:   8b 80 a8 09 00 00       mov    0x9a8(%eax),%eax 6:   8b 40 14                mov    0x14(%eax),%eax 9:   8b 50 70                mov    0x70(%eax),%edx <====
   c:   85 d2                   test   %edx,%edx
   e:   74 09                   je     0x19

and the marked line exploded on you.  The above instructions correspond with:

Quoted 6 lines

0:      struct serport *sp = (struct serport *) tty->disc_data; 6:      serio_drv_write_wakeup(sp->serio);
9:      if (serio->drv

So, "serio" was this strange 0xf3a6cdf8 value.  But why?  One for the input people I think.

Reuben, could you please try the patch below? Thanks!

Russell, could you please tell me if ldisc->write_wakeup (tty_wakwup) and ldisc->read are allowed to be called from an IRQ context? IOW I wonder if I can use spil_lock_bh instead of spil_lock_irqsave to protect serport flags.

Signature · 200 lines
Dmitry

 serport.c |   98 +++++++++++++++++++++++++++++++++++++++++++-------------------
 1 files changed, 68 insertions(+), 30 deletions(-)

Index: dtor/drivers/input/serio/serport.c
===================================================================
--- dtor.orig/drivers/input/serio/serport.c
+++ dtor/drivers/input/serio/serport.c
@@ -27,11 +27,15 @@ MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_MOUSE);
 
 #define SERPORT_BUSY	1
+#define SERPORT_ACTIVE	2
+#define SERPORT_DEAD	3
 
 struct serport {
 	struct tty_struct *tty;
 	wait_queue_head_t wait;
 	struct serio *serio;
+	struct serio_device_id id;
+	spinlock_t lock;
 	unsigned long flags;
 };
 
@@ -45,11 +49,29 @@ static int serport_serio_write(struct se
 	return -(serport->tty->driver->write(serport->tty, &data, 1) != 1);
 }
 
+static int serport_serio_open(struct serio *serio)
+{
+	struct serport *serport = serio->port_data;
+	unsigned long flags;
+
+	spin_lock_irqsave(&serport->lock, flags);
+	set_bit(SERPORT_ACTIVE, &serport->flags);
+	spin_unlock_irqrestore(&serport->lock, flags);
+
+	return 0;
+}
+
+
 static void serport_serio_close(struct serio *serio)
 {
 	struct serport *serport = serio->port_data;
+	unsigned long flags;
+
+	spin_lock_irqsave(&serport->lock, flags);
+	clear_bit(SERPORT_ACTIVE, &serport->flags);
+	set_bit(SERPORT_DEAD, &serport->flags);
+	spin_unlock_irqrestore(&serport->lock, flags);
 
-	serport->serio->id.type = 0;
 	wake_up_interruptible(&serport->wait);
 }
 
@@ -61,36 +83,21 @@ static void serport_serio_close(struct s
 static int serport_ldisc_open(struct tty_struct *tty)
 {
 	struct serport *serport;
-	struct serio *serio;
-	char name[64];
 
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
-	serport = kmalloc(sizeof(struct serport), GFP_KERNEL);
-	serio = kmalloc(sizeof(struct serio), GFP_KERNEL);
-	if (unlikely(!serport || !serio)) {
-		kfree(serport);
-		kfree(serio);
+	serport = kcalloc(1, sizeof(struct serport), GFP_KERNEL);
+	if (!serport)
 		return -ENOMEM;
-	}
 
-	memset(serport, 0, sizeof(struct serport));
-	serport->serio = serio;
-	set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
 	serport->tty = tty;
-	tty->disc_data = serport;
-
-	memset(serio, 0, sizeof(struct serio));
-	strlcpy(serio->name, "Serial port", sizeof(serio->name));
-	snprintf(serio->phys, sizeof(serio->phys), "%s/serio0", tty_name(tty, name));
-	serio->id.type = SERIO_RS232;
-	serio->write = serport_serio_write;
-	serio->close = serport_serio_close;
-	serio->port_data = serport;
-
+	spin_lock_init(&serport->lock);
 	init_waitqueue_head(&serport->wait);
 
+	tty->disc_data = serport;
+	set_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);
+
 	return 0;
 }
 
@@ -100,7 +107,8 @@ static int serport_ldisc_open(struct tty
 
 static void serport_ldisc_close(struct tty_struct *tty)
 {
-	struct serport *serport = (struct serport*) tty->disc_data;
+	struct serport *serport = (struct serport *) tty->disc_data;
+
 	kfree(serport);
 }
 
@@ -116,9 +124,19 @@ static void serport_ldisc_close(struct t
 static void serport_ldisc_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, int count)
 {
 	struct serport *serport = (struct serport*) tty->disc_data;
+	unsigned long flags;
 	int i;
+
+	spin_lock_irqsave(&serport->lock, flags);
+
+	if (!test_bit(SERPORT_ACTIVE, &serport->flags))
+		goto out;
+
 	for (i = 0; i < count; i++)
 		serio_interrupt(serport->serio, cp[i], 0, NULL);
+
+out:
+	spin_unlock_irqrestore(&serport->lock, flags);
 }
 
 /*
@@ -141,16 +159,33 @@ static int serport_ldisc_room(struct tty
 static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file, unsigned char __user * buf, size_t nr)
 {
 	struct serport *serport = (struct serport*) tty->disc_data;
+	struct serio *serio;
 	char name[64];
 
 	if (test_and_set_bit(SERPORT_BUSY, &serport->flags))
 		return -EBUSY;
 
+	serport->serio = serio = kcalloc(1, sizeof(struct serio), GFP_KERNEL);
+	if (!serio)
+		return -ENOMEM;
+
+	strlcpy(serio->name, "Serial port", sizeof(serio->name));
+	snprintf(serio->phys, sizeof(serio->phys), "%s/serio0", tty_name(tty, name));
+	serio->id = serport->id;
+	serio->id.type = SERIO_RS232;
+	serio->write = serport_serio_write;
+	serio->open = serport_serio_open;
+	serio->close = serport_serio_close;
+	serio->port_data = serport;
+
 	serio_register_port(serport->serio);
 	printk(KERN_INFO "serio: Serial port %s\n", tty_name(tty, name));
-	wait_event_interruptible(serport->wait, !serport->serio->id.type);
+
+	wait_event_interruptible(serport->wait, test_bit(SERPORT_DEAD, &serport->flags));
 	serio_unregister_port(serport->serio);
+	serport->serio = NULL;
 
+	clear_bit(SERPORT_DEAD, &serport->flags);
 	clear_bit(SERPORT_BUSY, &serport->flags);
 
 	return 0;
@@ -163,16 +198,15 @@ static ssize_t serport_ldisc_read(struct
 static int serport_ldisc_ioctl(struct tty_struct * tty, struct file * file, unsigned int cmd, unsigned long arg)
 {
 	struct serport *serport = (struct serport*) tty->disc_data;
-	struct serio *serio = serport->serio;
 	unsigned long type;
 
 	if (cmd == SPIOCSTYPE) {
 		if (get_user(type, (unsigned long __user *) arg))
 			return -EFAULT;
 
-		serio->id.proto	= type & 0x000000ff;
-		serio->id.id	= (type & 0x0000ff00) >> 8;
-		serio->id.extra	= (type & 0x00ff0000) >> 16;
+		serport->id.proto = type & 0x000000ff;
+		serport->id.id	  = (type & 0x0000ff00) >> 8;
+		serport->id.extra = (type & 0x00ff0000) >> 16;
 
 		return 0;
 	}
@@ -182,9 +216,13 @@ static int serport_ldisc_ioctl(struct tt
 
 static void serport_ldisc_write_wakeup(struct tty_struct * tty)
 {
-	struct serport *sp = (struct serport *) tty->disc_data;
+	struct serport *serport = (struct serport *) tty->disc_data;
+	unsigned long flags;
 
-	serio_drv_write_wakeup(sp->serio);
+	spin_lock_irqsave(&serport->lock, flags);
+	if (test_bit(SERPORT_ACTIVE, &serport->flags))
+		serio_drv_write_wakeup(serport->serio);
+	spin_unlock_irqrestore(&serport->lock, flags);
 }
 
 /*
#4 lore raw

Hi Dmitry and others,

Quoted 39 lines · Dmitry Torokhov
Quoted 12 lines · Russell King

Looks like something in the input layer went bang. The code in serport_ldisc_write_wakeup is:

   0:   8b 80 a8 09 00 00       mov    0x9a8(%eax),%eax
   6:   8b 40 14                mov    0x14(%eax),%eax
   9:   8b 50 70                mov    0x70(%eax),%edx <====
   c:   85 d2                   test   %edx,%edx
   e:   74 09                   je     0x19

and the marked line exploded on you. The above instructions correspond with:

Quoted 6 lines
0:      struct serport *sp = (struct serport *) tty->disc_data;
6:      serio_drv_write_wakeup(sp->serio);
9:      if (serio->drv

So, "serio" was this strange 0xf3a6cdf8 value. But why? One for the input people I think.

Reuben, could you please try the patch below? Thanks!

Russell, could you please tell me if ldisc->write_wakeup (tty_wakwup) and ldisc->read are allowed to be called from an IRQ context? IOW I wonder if I can use spil_lock_bh instead of spil_lock_irqsave to protect serport flags.

--
Dmitry

 serport.c |   98 
+++++++++++++++++++++++++++++++++++++++++++-------------------
 1 files changed, 68 insertions(+), 30 deletions(-)

Index: dtor/drivers/input/serio/serport.c
===================================================================

drivers/input/serio/serport.c MODULE_LICENSE("GPL"); · line 27

Quoted 1 line
drivers/input/serio/serport.c +0 -0
@@ -27,11 +27,15 @@ MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_MOUSE);

I've done some testing this afternoon and it seems that this patch fixes the problem in -mm4. I don't even have a serial mouse/keyboard, but do have a serial PCI card onboard. The box has a USB connection to a Belkin KVM instead of directly attached input devices.

I also note that it is occurring on kernel-smp-2.6.11-1.1219_FC4 - so it is probably a problem in mainline as well as -mm.

Now I'm crashing a bit further through the shutdown, here's the stacktrace:

INIT: Sending processes the TERM signal Stopping yum: Disabling nightly yum update: [ OK ] [ OK ]
Stopping cups-config-daemon: [ OK ] Stopping HAL daemon: [ OK ]
Stopping system message bus: [ OK ] Stopping atd: [ OK ]
Stopping cups: [ OK ]
Shutting down xfs: [ OK ]
[ OK ] down console mouse services: [ OK ] Shutting down NFS mountd: [ OK ]
Shutting down NFS daemon: nfsd: last server has exited
nfsd: unexporting all filesystems
RPC: error 5 connecting to server localhost
RPC: failed to contact portmap (errno -5).

Unable to handle kernel paging request at virtual address f2826d2c
 printing eip:
c01337a9
*pde = 00000000
Oops: 0000 [#1]
SMP DEBUG_PAGEALLOC
Modules linked in: nfsd exportfs md5 ipv6 lp snd_usb_audio snd_usb_lib pwc video

dev usb_storage autofs4 eeprom lm85 i2c_sensor rfcomm l2cap bluetooth nfs lockd sunrpc dm_mod video button battery ac ohci1394 ieee1394 uhci_hcd ehci_hcd parpor t_serial parport_pc parport hw_random i2c_i801 i2c_core emu10k1_gp gameport snd_ emu10k1 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm_oss snd_mixer_oss snd_ pcm snd_timer snd_page_alloc snd_util_mem snd_hwdep snd soundcore e100 mii flopp y ext3 jbd ata_piix libata sd_mod scsi_mod

CPU:    0
EIP:    0060:[<c01337a9>]    Not tainted VLI
EFLAGS: 00010087   (2.6.12-rc1-mm4)

EIP is at worker_thread+0x149/0x230
eax: 00000001 ebx: 00000212 ecx: f7eb4018 edx: f2826d20
esi: f2826d24 edi: f7eb4000 ebp: 00000000 esp: f7e83f7c
ds: 007b es: 007b ss: 0068
Process events/0 (pid: 8, threadinfo=f7e83000 task=f7fefad0)

Stack: f7eb4028 f7eb4010 f7eb4018 f7e83000 f2826d20 c014f4b0 00000001 00000000
       000f41fa 00010000 00000000 00000000 f7fefad0 c011ea50 00100100 00200200
       ffffffff ffffffff fffffffc f7e46f54 f7eb4000 c0133660 c0137694 ffffffff
Call Trace:
 [<c014f4b0>] cache_reap+0x0/0x240
 [<c011ea50>] default_wake_function+0x0/0x10
 [<c0133660>] worker_thread+0x0/0x230
 [<c0137694>] kthread+0x94/0xa0
 [<c0137600>] kthread+0x0/0xa0
 [<c01023f5>] kernel_thread_helper+0x5/0x10
Code: 00 00 89 f8 e8 19 e3 1e 00 89 c3 8b 47 40 40 89 47 40 83 f8 03 0f 8f bd 00
 00 00 8b 77 10 3b 74 24 04 74 71 8d 56 fc 89 54 24 10 <8b> 42 0c 89 
44 24 14 8b
 6a 10 8b 46 04 8b 16 89 10 89 36 89 42
 [  OK  ]
Shutting down NFS quotas: [FAILED]
Shutting down NFS services:  [  OK  ]
Stopping sshd: [  OK  ]
Stopping postfix:  Shutting down postfix: <3>BUG: soft lockup detected on CPU#0!

Pid: 3413, comm: rpc.rquotad
EIP: 0060:[<c0321ac0>] CPU: 0
EIP is at _spin_lock_irqsave+0x20/0x50
EFLAGS: 00000286 Not tainted (2.6.12-rc1-mm4)
EAX: f7eb4000 EBX: 00000246 ECX: f7eb4000 EDX: c22021a0
ESI: f7eb4000 EDI: c22021a0 EBP: c01335b0 DS: 007b ES: 007b
CR0: 8005003b CR2: 800147fc CR3: 37256d20 CR4: 000006e0

 [<c013350c>] __queue_work+0xc/0x50
 [<c012cc17>] run_timer_softirq+0xd7/0x1c0
 [<c0128950>] __do_softirq+0x80/0x100
 [<c0106adb>] do_softirq+0x4b/0x50
 =======================
 [<c010511c>] apic_timer_interrupt+0x1c/0x30
 [<c02b7ed8>] kfree_skbmem+0x8/0x20
 [<c02b007b>] cpufreq_governor+0x3b/0x50
 [<c014eed2>] kfree+0x62/0x90
 [<c02b7ed8>] kfree_skbmem+0x8/0x20
 [<c02b7fcc>] __kfree_skb+0xdc/0x1a0
 [<c02d2501>] netlink_recvmsg+0xf1/0x230
 [<c02b422a>] sock_recvmsg+0xfa/0x120
 [<c02b40d2>] sock_sendmsg+0xe2/0x110
 [<c0137b20>] autoremove_wake_function+0x0/0x30
 [<c0149d32>] __alloc_pages+0x122/0x440
 [<c01d94a2>] copy_from_user+0x42/0x80
 [<c02b5ba9>] sys_recvmsg+0x109/0x1e0
 [<c01d94a2>] copy_from_user+0x42/0x80
 [<c02b553e>] sys_sendto+0xfe/0x140
 [<c011a863>] do_page_fault+0x253/0x6a1
 [<c017c6a1>] d_alloc+0x141/0x1a0
 [<c01648d1>] fd_install+0x21/0x50
 [<c02b3e57>] sock_map_fd+0xf7/0x130
 [<c032068d>] schedule+0x97d/0xc10
 [<c02b5e67>] sys_socketcall+0x1e7/0x200
 [<c0103fbb>] sysenter_past_esp+0x54/0x79

System is an up to date FC4- devel box with a 2.8 Ghz SMP Intel processor.

reuben

#5 lore raw
Quoted 29 lines · Reuben Farrelly
Quoted 21 lines

Reuben, could you please try the patch below? Thanks!

Russell, could you please tell me if ldisc->write_wakeup (tty_wakwup) and ldisc->read are allowed to be called from an IRQ context? IOW I wonder if I can use spil_lock_bh instead of spil_lock_irqsave to protect serport flags.

--
Dmitry

 serport.c |   98 
+++++++++++++++++++++++++++++++++++++++++++-------------------
 1 files changed, 68 insertions(+), 30 deletions(-)

Index: dtor/drivers/input/serio/serport.c
===================================================================

drivers/input/serio/serport.c MODULE_LICENSE("GPL"); · line 27

Quoted 1 line
drivers/input/serio/serport.c +0 -0
@@ -27,11 +27,15 @@ MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_MOUSE);

I've done some testing this afternoon and it seems that this patch fixes the problem in -mm4. I don't even have a serial mouse/keyboard, but do have a serial PCI card onboard. The box has a USB connection to a Belkin KVM instead of directly attached input devices.

Quoted 2 lines

I also note that it is occurring on kernel-smp-2.6.11-1.1219_FC4 - so it is probably a problem in mainline as well as -mm.

Can you please confirm that the above fix is present in 2.6.12-rc5 and that 2.6.12-rc5 is working OK?

Quoted 2 lines

Now I'm crashing a bit further through the shutdown, here's the stacktrace:

Is this still occurring in either 2.6.12-rc5 or 2.6.12-rc5-mm1?

Quoted 102 lines

INIT: Sending processes the TERM signal Stopping yum: Disabling nightly yum update: [ OK ] [ OK ]
Stopping cups-config-daemon: [ OK ] Stopping HAL daemon: [ OK ]
Stopping system message bus: [ OK ] Stopping atd: [ OK ]
Stopping cups: [ OK ]
Shutting down xfs: [ OK ]
[ OK ] down console mouse services: [ OK ] Shutting down NFS mountd: [ OK ]
Shutting down NFS daemon: nfsd: last server has exited
nfsd: unexporting all filesystems
RPC: error 5 connecting to server localhost
RPC: failed to contact portmap (errno -5).

Unable to handle kernel paging request at virtual address f2826d2c
  printing eip:
c01337a9
*pde = 00000000
Oops: 0000 [#1]
SMP DEBUG_PAGEALLOC
Modules linked in: nfsd exportfs md5 ipv6 lp snd_usb_audio 

snd_usb_lib pwc video
dev usb_storage autofs4 eeprom lm85 i2c_sensor rfcomm l2cap bluetooth nfs lockd sunrpc dm_mod video button battery ac ohci1394 ieee1394 uhci_hcd ehci_hcd parpor
t_serial parport_pc parport hw_random i2c_i801 i2c_core emu10k1_gp gameport snd_
emu10k1 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm_oss snd_mixer_oss snd_
pcm snd_timer snd_page_alloc snd_util_mem snd_hwdep snd soundcore e100 mii flopp
y ext3 jbd ata_piix libata sd_mod scsi_mod

CPU:    0
EIP:    0060:[<c01337a9>]    Not tainted VLI
EFLAGS: 00010087   (2.6.12-rc1-mm4)

EIP is at worker_thread+0x149/0x230
eax: 00000001 ebx: 00000212 ecx: f7eb4018 edx: f2826d20
esi: f2826d24 edi: f7eb4000 ebp: 00000000 esp: f7e83f7c
ds: 007b es: 007b ss: 0068
Process events/0 (pid: 8, threadinfo=f7e83000 task=f7fefad0)

Stack: f7eb4028 f7eb4010 f7eb4018 f7e83000 f2826d20 c014f4b0 00000001 00000000
        000f41fa 00010000 00000000 00000000 f7fefad0 c011ea50 00100100 00200200
        ffffffff ffffffff fffffffc f7e46f54 f7eb4000 c0133660 c0137694 ffffffff
Call Trace:
  [<c014f4b0>] cache_reap+0x0/0x240
  [<c011ea50>] default_wake_function+0x0/0x10
  [<c0133660>] worker_thread+0x0/0x230
  [<c0137694>] kthread+0x94/0xa0
  [<c0137600>] kthread+0x0/0xa0
  [<c01023f5>] kernel_thread_helper+0x5/0x10
Code: 00 00 89 f8 e8 19 e3 1e 00 89 c3 8b 47 40 40 89 47 40 83 f8 03 

0f 8f bd 00
00 00 8b 77 10 3b 74 24 04 74 71 8d 56 fc 89 54 24 10 <8b> 42 0c 89
44 24 14 8b
6a 10 8b 46 04 8b 16 89 10 89 36 89 42
[ OK ]

Shutting down NFS quotas: [FAILED]
Shutting down NFS services:  [  OK  ]
Stopping sshd: [  OK  ]
Stopping postfix:  Shutting down postfix: <3>BUG: soft lockup 

detected on CPU#0!

Pid: 3413, comm: rpc.rquotad
EIP: 0060:[<c0321ac0>] CPU: 0
EIP is at _spin_lock_irqsave+0x20/0x50
EFLAGS: 00000286 Not tainted (2.6.12-rc1-mm4)
EAX: f7eb4000 EBX: 00000246 ECX: f7eb4000 EDX: c22021a0
ESI: f7eb4000 EDI: c22021a0 EBP: c01335b0 DS: 007b ES: 007b
CR0: 8005003b CR2: 800147fc CR3: 37256d20 CR4: 000006e0

  [<c013350c>] __queue_work+0xc/0x50
  [<c012cc17>] run_timer_softirq+0xd7/0x1c0
  [<c0128950>] __do_softirq+0x80/0x100
  [<c0106adb>] do_softirq+0x4b/0x50
  =======================
  [<c010511c>] apic_timer_interrupt+0x1c/0x30
  [<c02b7ed8>] kfree_skbmem+0x8/0x20
  [<c02b007b>] cpufreq_governor+0x3b/0x50
  [<c014eed2>] kfree+0x62/0x90
  [<c02b7ed8>] kfree_skbmem+0x8/0x20
  [<c02b7fcc>] __kfree_skb+0xdc/0x1a0
  [<c02d2501>] netlink_recvmsg+0xf1/0x230
  [<c02b422a>] sock_recvmsg+0xfa/0x120
  [<c02b40d2>] sock_sendmsg+0xe2/0x110
  [<c0137b20>] autoremove_wake_function+0x0/0x30
  [<c0149d32>] __alloc_pages+0x122/0x440
  [<c01d94a2>] copy_from_user+0x42/0x80
  [<c02b5ba9>] sys_recvmsg+0x109/0x1e0
  [<c01d94a2>] copy_from_user+0x42/0x80
  [<c02b553e>] sys_sendto+0xfe/0x140
  [<c011a863>] do_page_fault+0x253/0x6a1
  [<c017c6a1>] d_alloc+0x141/0x1a0
  [<c01648d1>] fd_install+0x21/0x50
  [<c02b3e57>] sock_map_fd+0xf7/0x130
  [<c032068d>] schedule+0x97d/0xc10
  [<c02b5e67>] sys_socketcall+0x1e7/0x200
  [<c0103fbb>] sysenter_past_esp+0x54/0x79

System is an up to date FC4- devel box with a 2.8 Ghz SMP Intel processor.

reuben

#6 lore raw

Hi,

Quoted 26 lines · Andrew Morton
Quoted 24 lines · Reuben Farrelly
Quoted 19 lines

Reuben, could you please try the patch below? Thanks!

Russell, could you please tell me if ldisc->write_wakeup (tty_wakwup) and ldisc->read are allowed to be called from an IRQ context? IOW I wonder if I can use spil_lock_bh instead of spil_lock_irqsave to protect serport flags.

--
Dmitry

serport.c | 98
+++++++++++++++++++++++++++++++++++++++++++-------------------

1 files changed, 68 insertions(+), 30 deletions(-)

Index: dtor/drivers/input/serio/serport.c
===================================================================

drivers/input/serio/serport.c MODULE_LICENSE("GPL"); · line 27

Quoted 1 line
drivers/input/serio/serport.c +0 -0
@@ -27,11 +27,15 @@ MODULE_LICENSE("GPL");
 MODULE_ALIAS_LDISC(N_MOUSE);

I've done some testing this afternoon and it seems that this patch fixes the problem in -mm4. I don't even have a serial mouse/keyboard, but do have a serial PCI card onboard. The box has a USB connection to a Belkin KVM instead of directly attached input devices.

Quoted 5 lines
Quoted 1 line

I also note that it is occurring on kernel-smp-2.6.11-1.1219_FC4 - so it is probably a problem in mainline as well as -mm.

Can you please confirm that the above fix is present in 2.6.12-rc5 and that 2.6.12-rc5 is working OK?

The fix is definitely in -rc5 (thanks), and without doubt fixed the problem I was seeing (thanks Dmitry). I haven't tested on a vanilla 2.6.12-rc5, but I can confirm that 2.6.12-rc4-mm* releases have not had the problem. The patch was of course in -rc4-mm* and possibly earlier?

Quoted 4 lines
Quoted 1 line
Quoted 1 line

Now I'm crashing a bit further through the shutdown, here's the stacktrace:

Is this still occurring in either 2.6.12-rc5 or 2.6.12-rc5-mm1?

2.6.12-rc4-mm* releases have been stable, I haven't seen any oopses for a few weeks now.

If confirmation is required in -rc5 then I'm happy to attempt this, but I don't think it's at all likely given I haven't seen any oopses at all since that patch was included in -mm, and the patch is now in upstream.

Btw, I didn't see a lkml-announce message about -rc5-mm1 being released :( No big deal really...

reuben

#7 lore raw
In reply to Reuben Farrelly
Quoted 10 lines · Reuben Farrelly

Hi,

Quoted 7 lines · Andrew Morton

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.12-rc1/2.6.12-rc1-mm3/

- Mainly a bunch of fixes relative to 2.6.12-rc1-mm2.

- Again, we'd like people who have had recent DRM and USB resume problems to test and report, please.

Quoted 9 lines
Quoted 5 lines

- The bk-ide-dev tree is back after a couple of weeks of difficulties.

- Jeff asks that anyone who has had problems with the Silicon Image SATA drivers test sata_sil-corruption--lockup-fix.patch, which is included in this kernel.

I'm repeatably getting this crash on shutdown in -mm3, and a few releases earlier (but I can't be certain it was the same crash..)

It would be nice to know when it started breaking... At least point release, not -rc or -bk.

Signature · 1 line
Dmitry