Skip to contentSkip to conversation

print an explanation why i810 fb doesn't come up

PATCH In review Denis Vlasenko 2 participants 2 messages Mar 28, 2005 – Apr 14, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 print an explanation why i810 fb doesn't come up

I've spent silly amonunt of time trying to use i810 fb on my new spiffy flat panel. This patch will hopefully help other poor souls.

Patch also fixes module parameter comments.
--
vda

drivers/video/i810/i810_main.c renamed from drivers/video/i810/i810_main.c.orig +9 -3
@@ -999,8 +999,14 @@ static int i810_check_params(struct fb_v
 	info->monspecs.dclkmin = 15000000;
 
 	if (fb_validate_mode(var, info)) {
-		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info))
+		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info)) {
+			int default_sync = (hsync1-HFMIN)|(hsync2-HFMAX)
+					    |(vsync1-VFMIN)|(vsync2-VFMAX);
+			printk("i810fb: invalid video mode%s\n",
+			    default_sync ? "" : 
+			    ". Specifying vsyncN/hsyncN parameters may help");
 			return -EINVAL;
+		}
 	}
 	
 	var->xres = xres;
@@ -2020,10 +2026,10 @@ MODULE_PARM_DESC(vyres, "Virtual vertica
 		 " (default = 480)");
 module_param(hsync1, int, 0);
 MODULE_PARM_DESC(hsync1, "Minimum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 29)");
 module_param(hsync2, int, 0);
 MODULE_PARM_DESC(hsync2, "Maximum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 30)");
 module_param(vsync1, int, 0);
 MODULE_PARM_DESC(vsync1, "Minimum vertical frequency of monitor in Hz"
 		 " (default = 50)");
#1 lore raw
Quoted 4 lines · Denis Vlasenko

I've spent silly amonunt of time trying to use i810 fb on my new spiffy flat panel. This patch will hopefully help other poor souls.

Patch also fixes module parameter comments.

Thanks, should help.

Tony