Skip to contentSkip to conversation

pcnet32: 79C975 fiber fix

PATCH Applied Don Fry 2 participants 2 messages Mar 28, 2005 – Mar 31, 2005

Subsystems (2)
lore
Share & tools
lore

Don Fry

author
#0 lore raw

PATCH 1/1 pcnet32: 79C975 fiber fix

From: "HARDY, Steven" <[email protected]>

I have found a bug in the pcnet32 driver (drivers/net/pcnet32.c) affecting all ethernet cards based on the AMD79C975 chip, using the fiber interface.

It's a one line fix, where some config registers get corrupted during initialisation (which stops the Fiber interface working with this chip)

This bug was introduced somewhere betweeen 2.4.17 and 2.6.x (noticed whilst upgrading to 2.6), and it may affect other chips too. I have checked all versions up to 2.6.11-bk6 and they are all broken.

drivers/net/pcnet32.c renamed from drivers/net/orig.pcnet32.c +2 -1
@@ -1351,7 +1351,8 @@ pcnet32_probe1(unsigned long ioaddr, int
 	printk(KERN_INFO "%s: registered as %s\n", dev->name, lp->name);
     cards_found++;
 
-    a->write_bcr(ioaddr, 2, 0x1002);	/* enable LED writes */
+    /* enable LED writes */
+    a->write_bcr(ioaddr, 2, a->read_bcr(ioaddr, 2) | 0x1000);
 
     return 0;
 
Signature · 2 lines
Don Fry
[email protected]