Skip to contentSkip to conversation

AGP causing instant crash on zx1-based systems

DISCUSSION David Mosberger 1 participant 1 message Mar 29, 2005

lore
Share & tools
lore
#0 lore raw

Dave,

It appears that one of your (relatively) recent changes to agp/generic.c is assuming that all AGP bridges are PCI devices. You may remember that this isn't the case for the zx1 AGP bridge (which is an ACPI-described device).

In particular, I'm seeing crashes due to the call to check_agp_bridgemode(). I suppose hp-agp.c could provide its own versions of the "generic.c" functions which use this function but it seems that would lead to lots of code duplication and would make things more fragile. Perhaps it's possible to put this info somewhere in the agp_bridge_data so that each backend can initializat it on its own?

Or did you have something else in mind here?

Thanks,

	--david