Skip to contentSkip to conversation

Fix tg3 driver disable interrupts bug for realtime-preempt-2.6.12-rc1-V0.7.41-14

PATCH New Guillaume Foliard 1 participant 1 message Mar 29, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix tg3 driver disable interrupts bug for realtime-preempt-2.6.12-rc1-V0.7.41-14

Hi,

I just noticed you've accepted a patch from Yang Yi dealing with interrupts in the e1000 drivers on a PREEMPT_RT kernel. I did not yet understood the problem but I blindly applied the same fix on the tg3 driver to get rid of the following message :

network driver disabled interrupts: tg3_start_xmit+0x0/0x620

drivers/net/tg3.c 2005-03-29 20:25:33 +0200 renamed from drivers/net/tg3.c 2005-03-18 02:34:13 +0100 +2 -2
@@ -3085,9 +3085,9 @@ static int tg3_start_xmit(struct sk_buff
         * So we really do need to disable interrupts when taking
         * tx_lock here.
         */
-       local_irq_save(flags);
+       local_irq_save_nort(flags);
        if (!spin_trylock(&tp->tx_lock)) {
-               local_irq_restore(flags);
+               local_irq_restore_nort(flags);
                return NETDEV_TX_LOCKED;
        }