Skip to contentSkip to conversation

netem with prio hangs on duplicate

LARTC js si 3 participants 3 messages Mar 30, 2005 – Apr 4, 2005

Subsystems (2)
lore
Share & tools
lore

js si

author
#0 lore raw

hi

i tried the example given on the examples page to duplicate selected traffic like

tc qdisc add dev eth0 root handle 1: prio
tc qdisc add dev eth0 parent 1:3 handle 3: netem duplicate 40%
tc filter add dev eth0 protocol ip parent 1:0 prio 3 u32 match ip dst 11.0.2.2 flowid 1:3

when i ping from 11.0.2.2 to this interface my machine hangs. the same thing works for drop or delay.

i would appreciate if someone can tell me what i am doing wrong.

thanks.

__________________________________
Do you Yahoo!?
Yahoo! Small Business - Try our new resources site!
http://smallbusiness.yahoo.com/resources/
_______________________________________________
LARTC mailing list
[email protected]
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc

#1 lore raw
Quoted 11 lines · js si

hi

i tried the example given on the examples page to duplicate selected traffic like

tc qdisc add dev eth0 root handle 1: prio
tc qdisc add dev eth0 parent 1:3 handle 3: netem duplicate 40%
tc filter add dev eth0 protocol ip parent 1:0 prio 3 u32 match ip dst 11.0.2.2 flowid 1:3

Quoted 5 lines

when i ping from 11.0.2.2 to this interface my machine hangs. the same thing works for drop or delay.

i would appreciate if someone can tell me what i am doing wrong.

Using netem with an upper qdisc screws up the upper qdisc's q.qlen counter and qdisc_run() tries to dequeue it indefinitely. I don't know whether netem is intended to be useable only as top-level qdisc, if so it should make sure that it really is used this way to avoid hanging the system.

Regards
Patrick
_______________________________________________
LARTC mailing list
[email protected]
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc

#2 lore raw
In reply to js si
Quoted 11 lines · On Wed, 30 Mar 2005 10:05:04 -0800 (PST) js si <[email protected]> wrote:

hi

i tried the example given on the examples page to duplicate selected traffic like

tc qdisc add dev eth0 root handle 1: prio
tc qdisc add dev eth0 parent 1:3 handle 3: netem duplicate 40%
tc filter add dev eth0 protocol ip parent 1:0 prio 3 u32 match ip dst 11.0.2.2 flowid 1:3

Try this. qdisc_restart() has a bug. It will spin until packet becomes available, which is wrong. This effects both netem and tbf, maybe other qdisc as well.

net/sched/sch_generic.c +3 -3
@@ -176,10 +176,10 @@ int qdisc_restart(struct net_device *dev
 
 requeue:
 		q->ops->requeue(skb, q);
-		netif_schedule(dev);
-		return 1;
+		netif_schedule(dev);	
+		return q->q.qlen;
 	}
-	return q->q.qlen;
+	return 0;
 }
 
 static void dev_watchdog(unsigned long arg)

_______________________________________________
LARTC mailing list
[email protected]
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc