Skip to contentSkip to conversation

I2C: via686a cleanups

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 I2C: via686a cleanups

Hi Greg,

Here comes a small cleanup patch for the via686a driver. I noticed the following two non-fatal problems:

1* The device parent is explicitely set, but it's not needed because the i2c core will do as the client is registered.

2* snprintf is used where strlcpy would suffice.

Fixing them brings the via686a driver in line with what other similar drivers do.

Please apply,
thanks.

Signed-off-by Jean Delvare <[email protected]>
drivers/i2c/chips/via686a.c renamed from drivers/i2c/chips/via686a.c.orig +1 -2
@@ -651,10 +651,9 @@
 	new_client->adapter = adapter;
 	new_client->driver = &via686a_driver;
 	new_client->flags = 0;
-	new_client->dev.parent = &adapter->dev;
 
 	/* Fill in the remaining client fields and put into the global list */
-	snprintf(new_client->name, I2C_NAME_SIZE, client_name);
+	strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
 
 	data->valid = 0;
 	init_MUTEX(&data->update_lock);
Signature · 1 line
Jean Delvare
Applied
#1 lore raw

PATCH 1/1 I2C: via686a cleanups

Quoted 8 lines · Jean Delvare

Hi Greg,

Here comes a small cleanup patch for the via686a driver. I noticed the following two non-fatal problems:

1* The device parent is explicitely set, but it's not needed because the i2c core will do as the client is registered.

Quoted 6 lines

2* snprintf is used where strlcpy would suffice.

Fixing them brings the via686a driver in line with what other similar drivers do.

Please apply,

Applied, thanks.

greg k-h