Skip to contentSkip to conversation

fix uninitialized proto_list_lock

PATCH In review Benjamin LaHaise 3 participants 3 messages Apr 4, 2005

Subsystems (3)
Networking Network drivers Sockets
lore
Share & tools
lore

Benjamin LaHaise

author
#0 lore raw

PATCH 1/1 fix uninitialized proto_list_lock

Please apply the following patch which fixes a BUG() on boot when the kernel is compiled with spinlock debugging in bk head. Cheers,

-ben

===== net/core/sock.c 1.67 vs edited =====

net/core/sock.c +1 -1
@@ -1352,7 +1352,7 @@
 
 EXPORT_SYMBOL(sk_common_release);
 
-static rwlock_t proto_list_lock;
+static rwlock_t proto_list_lock = RW_LOCK_UNLOCKED;
 static LIST_HEAD(proto_list);
 
 int proto_register(struct proto *prot, int alloc_slab)
#1 lore raw
Quoted 2 lines · On Mon, 4 Apr 2005 13:30:10 -0400 Benjamin LaHaise <[email protected]> wrote:

Please apply the following patch which fixes a BUG() on boot when the kernel is compiled with spinlock debugging in bk head. Cheers,

This is already in Linus's tree.
Thanks.

#2 lore raw
In reply to Benjamin LaHaise
Quoted 9 lines · Benjamin LaHaise

Please apply the following patch which fixes a BUG() on boot when the kernel is compiled with spinlock debugging in bk head. Cheers,

-ben

===== net/core/sock.c 1.67 vs edited =====

net/core/sock.c 2005-04-04 12:46:26 -04:00 line 1355

Quoted 5 lines
net/core/sock.c 2005-04-04 12:46:26 -04:00 renamed from net/core/sock.c 2005-03-26 18:04:35 -05:00 +1 -1
@@ -1352,7 +1352,7 @@
 
 EXPORT_SYMBOL(sk_common_release);
 
-static rwlock_t proto_list_lock;
+static rwlock_t proto_list_lock = RW_LOCK_UNLOCKED;

This was already fixed by James Bottomley and its in Dave tree waiting for Linus to do a pull.

Thanks anyway!

- Arnaldo