--ignorelockingfailure for `lvm mkvgnodes`

Hi,

lvm vgmknodes needs --ignorevglocking. Consider following scenario:
- just after initrd finishes, everything is activated
- /dev is mount as tmpfs, read-write, managed by udev
- other filesystem hovewer are mounted read-only
- /var could be not mounted at all!

- filesystem are going to be remounted rw after fsck. But fsck won't run, as there are LVM nodes missing from /dev. fsck error == fatal condition
- lvm vgmknodes won't run, because it can't obtain lock in /var. But should work, as /dev is writable

Attached trivial patch adds --ignorelockingfailure to vgmknodes. It is
pretty safe.

I've ecnountered above scenario on Slackware system during migration to
LVM2.

Tomasz Torcz               "Never underestimate the bandwidth of a station
[email protected]    wagon filled with backup tapes." -- Jim Gray

diff -ru LVM2.old/tools/commands.h LVM2.new/tools/commands.h
@@ -717,9 +717,12 @@
    "vgmknodes\n"
    "\t[-d|--debug]\n"
    "\t[-h|--help]\n"
+   "\t[--ignorelockingfailure]\n"
    "\t[-v|--verbose]\n"
    "\t[--version]" "\n"
-   "\t[VolumeGroupName...]\n" )
+   "\t[VolumeGroupName...]\n",
+
+   ignorelockingfailure_ARG)
 
 xx(vgreduce,
    "Remove physical volume(s) from a volume group",

Agreed - though for different reasons (I won't go into here).

'vgscan --mknodes --ignorelockingfailure' is normally adequate, and looks to be so in your case?

Alasdair

[email protected]

so you mean
vgscan
vgchange -a y
vgscan --mknodes
???

Btw, i added man page to Tomasz patch

L.

Luca Berra -- [email protected]
       Communication Media & Services S.r.l.
/"\
\ /     ASCII RIBBON CAMPAIGN
 X        AGAINST HTML MAIL
/ \