Skip to contentSkip to conversation

Bug with multiple help messages, the last one is shown

DISCUSSION Blaisorblade 2 participants 3 messages Mar 22, 2005 – Apr 5, 2005

lore
Share & tools
lore
#0 lore raw

I've verified multiple times that if we have a situation like this

bool A
depends on TRUE
help
Bla bla1

and

bool A
depends on FALSE
help
Bla bla2

even if the first option is the displayed one, the help text used is the one for the second option (the absence of "prompt" is not relevant here)!

Quoted 1 line

From a very short reading of sources, I guess that the problem is probably

located in this line (from scripts/kconfig/zconf.y):

help: help_start T_HELPTEXT

{
        current_entry->sym->help = $2;
};

because the various current_entry values (matching the various definitions) share the same symbol (since of the sym_lookup call below)

config_entry_start: T_CONFIG T_WORD T_EOL

{
        struct symbol *sym = sym_lookup($2, 0);
        sym->flags |= SYMBOL_OPTIONAL;
        menu_add_entry(sym);
        printd(DEBUG_PARSE, "%s:%d:config %s\n", zconf_curname(), 

zconf_lineno(), $2);
};

Now, Kconfig handles well the same situation when there are multiple different prompts, instead of multiple help texts.

This because the "prompt" is added as a property with its own dependency; why is not this done for "help", too?

Signature · 3 lines
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
#1 lore raw

Hi,

Quoted 9 lines · Blaisorblade

I've verified multiple times that if we have a situation like this

bool A
depends on TRUE
help
Bla bla1

and

Quoted 7 lines

bool A
depends on FALSE
help
Bla bla2

even if the first option is the displayed one, the help text used is the one for the second option (the absence of "prompt" is not relevant here)!

Is this based on a real problem? I know that there's currently one help text per symbol and the behaviour for multiple help texts is basically undefined.

bye, Roman

#2 lore raw

Sorry for the late answer, Yahoo put your mail in its Spam folder, and I didn't check until now.

Quoted 17 lines · Roman Zippel

Hi,

Quoted 14 lines · Blaisorblade

I've verified multiple times that if we have a situation like this

bool A
depends on TRUE
help
Bla bla1

and

bool A
depends on FALSE
help
Bla bla2

Quoted 4 lines
Quoted 2 lines

even if the first option is the displayed one, the help text used is the one for the second option (the absence of "prompt" is not relevant here)!

Is this based on a real problem?

Yes, look at the multiple help texts in lib/Kconfig.debug in vanilla 2.6.11, or, in the current bk tree, in lib/Kconfig.debug and arch/um/Kconfig for MAGIC_SYSRQ. For UML we need different help texts, so I'd like this solved.

If you definitely don't want to fix this, we can use the old 2.4 trick of having CONFIG_MAGIC_SYSRQ2, for instance, with the right help and defining MAGIC_SYSRQ as equal to MAGIC_SYSRQ2.

Quoted 5 lines

I know that there's currently one help
text per symbol

and the behaviour for multiple help texts is basically undefined.

Yes, it's what I saw (actually I guess and seem to have verified that the last read text is used).

Signature · 3 lines
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade