Skip to contentSkip to conversation

drivers/media/dvb/b2c2/skystar2.c: remove an impossible code path

PATCH New Adrian Bunk 1 participant 1 message Apr 9, 2005 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/media/dvb/b2c2/skystar2.c: remove an impossible code path

This patch removes an impossible code path found by the Coverity checker (look at the assignement in the first line of the context).

---

 drivers/media/dvb/b2c2/skystar2.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb/b2c2/skystar2.c renamed from drivers/media/dvb/b2c2/skystar2.c.old +1 -1
@@ -1358,49 +1358,49 @@ static int dma_init_dma(struct adapter *
 		subbuffers = 2;
 
 		subbufsize = (((adapter->dmaq1.buffer_size / 2) / 4) << 8) | subbuffers;
 
 		subbuf0 = adapter->dmaq1.bus_addr & 0xfffffffc;
 
 		subbuf1 = ((adapter->dmaq1.bus_addr + adapter->dmaq1.buffer_size / 2) & 0xfffffffc) | 1;
 
 		dprintk("%s: first subbuffer address = 0x%x\n", __FUNCTION__, subbuf0);
 		udelay(1000);
 		write_reg_dw(adapter, 0x000, subbuf0);
 
 		dprintk("%s: subbuffer size = 0x%x\n", __FUNCTION__, (subbufsize >> 8) * 4);
 		udelay(1000);
 		write_reg_dw(adapter, 0x004, subbufsize);
 
 		dprintk("%s: second subbuffer address = 0x%x\n", __FUNCTION__, subbuf1);
 		udelay(1000);
 		write_reg_dw(adapter, 0x00c, subbuf1);
 
 		dprintk("%s: counter = 0x%x\n", __FUNCTION__, adapter->dmaq1.bus_addr & 0xfffffffc);
 		write_reg_dw(adapter, 0x008, adapter->dmaq1.bus_addr & 0xfffffffc);
 		udelay(1000);
 
-		dma_enable_disable_irq(adapter, 0, 1, subbuffers ? 1 : 0);
+		dma_enable_disable_irq(adapter, 0, 1, 1);
 
 		irq_dma_enable_disable_irq(adapter, 1);
 
 		sram_set_media_dest(adapter, 1);
 		sram_set_net_dest(adapter, 1);
 		sram_set_cai_dest(adapter, 2);
 		sram_set_cao_dest(adapter, 2);
 	}
 
 	if (dma_channel == 1) {
 		dprintk("%s: Initializing DMA2 channel\n", __FUNCTION__);
 
 		subbuffers = 2;
 
 		subbufsize = (((adapter->dmaq2.buffer_size / 2) / 4) << 8) | subbuffers;
 
 		subbuf0 = adapter->dmaq2.bus_addr & 0xfffffffc;
 
 		subbuf1 = ((adapter->dmaq2.bus_addr + adapter->dmaq2.buffer_size / 2) & 0xfffffffc) | 1;
 
 		dprintk("%s: first subbuffer address = 0x%x\n", __FUNCTION__, subbuf0);
 		udelay(1000);
 		write_reg_dw(adapter, 0x010, subbuf0);