Oops in swsusp
Pavel,
during testing of the encrypted swsusp_image on x86_64 I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy in copy_data_pages() of swsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).
This Oops seems to be unrelated to the encrypted image addition as I didn't touch any code in that area.
Signature · 1 line
Andreas Steinmetz SPAMmers use [email protected]
Hi,
Quoted 6 lines · Andreas Steinmetz
Pavel,
during testing of the encryptedswsusp_imageonx86_64I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy incopy_data_pages()ofswsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).
It's quite important, however. If it's the destination, it's probably a bug in swsusp. Otherwise, the problem is more serious. Could you, please, add BUG_ON(!pbe->address) right before the memcpy() and retest?
Greets,
Rafael
Signature · 3 lines
- Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland"
Quoted 12 lines · Rafael J. Wysocki
Hi,
Quoted 6 lines · Andreas Steinmetz
Pavel,
during testing of the encryptedswsusp_imageonx86_64I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy incopy_data_pages()ofswsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).
Quoted 3 lines
It's quite important, however. If it's the destination, it's probably a bug in swsusp. Otherwise, the problem is more serious. Could you, please, add
BUG_ON(!pbe->address)right before thememcpy()and retest?
I'll try.
Signature · 1 line
Andreas Steinmetz SPAMmers use [email protected]
Quoted 12 lines · Rafael J. Wysocki
Hi,
Quoted 6 lines · Andreas Steinmetz
Pavel,
during testing of the encryptedswsusp_imageonx86_64I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy incopy_data_pages()ofswsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).
Quoted 3 lines
It's quite important, however. If it's the destination, it's probably a bug in swsusp. Otherwise, the problem is more serious. Could you, please, add
BUG_ON(!pbe->address)right before thememcpy()and retest?
Here's the result:
BUG_ON(!pbe->address) hits, so is seems to be a swsusp problem.
So I added a BUG_ON(!to_copy) as shown below (mangled for mailing):
if (saveable(zone, &zone_pfn)) {
struct page * page;
BUG_ON(!to_copy);
page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
pbe->orig_address = (long) page_address(page);
/* copy_page is not usable for copying task structs. */
BUG_ON(!pbe->address);
memcpy((void *)pbe->address, (void *)pbe->orig_address,
PAGE_SIZE);
pbe++;
to_copy--;
}The BUG_ON(!to_copy) hits, too.
So it seems that the result sum of saveable() increases between count_data_pages() and copy_data_pages(). The problem seems to be easiest hit when starting a larger GUI application and suspending during application startup. It does ususally take a few suspend/resume iterations to hit the bug.
Pavel,
the crypto stuff in swsusp.c starts in data_write() which is called after copy_data_pages() if I'm right. In this case the crypto stuff can't be the culprit.
Signature · 1 line
Andreas Steinmetz SPAMmers use [email protected]
Hi,
Quoted 36 lines · Andreas Steinmetz
Quoted 12 lines · Rafael J. Wysocki
Hi,
Quoted 6 lines · Andreas Steinmetz
Pavel,
during testing of the encryptedswsusp_imageonx86_64I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy incopy_data_pages()ofswsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).Quoted 3 lines
It's quite important, however. If it's the destination, it's probably a bug in swsusp. Otherwise, the problem is more serious. Could you, please, add
BUG_ON(!pbe->address)right before thememcpy()and retest?Here's the result:
BUG_ON(!pbe->address)hits, so is seems to be a swsusp problem.So I added a
BUG_ON(!to_copy)as shown below (mangled for mailing):if (saveable(zone, &zone_pfn)) { struct page * page; BUG_ON(!to_copy); page = pfn_to_page(zone_pfn + zone->zone_start_pfn); pbe->orig_address = (long) page_address(page); /* copy_page is not usable for copying task structs. */ BUG_ON(!pbe->address); memcpy((void *)pbe->address, (void *)pbe->orig_address, PAGE_SIZE); pbe++; to_copy--; }
Quoted 1 line
The
BUG_ON(!to_copy)hits, too.
Oh, I see. You have discovered a bug in the code that was replaced in 2.6.12-rc1. :-) Please use 2.6.12-rc2 or the latest -mm for testing/development of swsusp.
Greets,
Rafael
Signature · 3 lines
- Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland"
Hi!
Quoted 7 lines
during testing of the encrypted
swsusp_imageonx86_64I did get an Oops from time to time at memcpy+11 called from swsusp_save+1090 which turns out to be the memcpy incopy_data_pages()ofswsusp.c.
The Oops is caused by a NULL pointer (I don't remember if it was source or destination).
This Oops seems to be unrelated to the encrypted image addition as I didn't touch any code in that area.
Could you still try to reproduce without any patches? Alocating memory at wrong moment may cause something like that, and crypto routines might do that.
Pavel
Signature · 1 line
Boycott Kodak -- for their patent abuse against Java.