Skip to contentSkip to conversation

arm: add comment about dma_supported()

PATCH In review [email protected] 1 participant 1 message Apr 12, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 5/198 arm: add comment about dma_supported()

From: Russell King <[email protected]>

The ARM dma_supported() is rather basic, and I don't think it takes into account everything that it should do (eg, whether the mask agrees with what we'd return for GFP_DMA allocations). Note this.

---

 25-akpm/include/asm-arm/dma-mapping.h |    3 +++
 1 files changed, 3 insertions(+)
include/asm-arm/dma-mapping.h renamed from include/asm-arm/dma-mapping.h~arm-add-comment-about-dma_supported +3 -0
diff -puN include/asm-arm/dma-mapping.h~arm-add-comment-about-dma_supported include/asm-arm/dma-mapping.h
@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr,
  * properly.  For example, if your device can only drive the low 24-bits
  * during bus mastering, then you would pass 0x00ffffff as the mask
  * to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
  */
 static inline int dma_supported(struct device *dev, u64 mask)
 {

_