Skip to contentSkip to conversation

unexport panic_timeout

PATCH In review Adrian Bunk 2 participants 3 messages Apr 15, 2005 – May 2, 2005 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unexport panic_timeout

I didn't find any possible modular usage in the kernel.

---

This patch was already sent on:
- 4 Mar 2005

kernel/panic.c renamed from kernel/panic.c.old +0 -2
@@ -24,8 +24,6 @@
 int panic_on_oops;
 int tainted;
 
-EXPORT_SYMBOL(panic_timeout);
-
 struct notifier_block *panic_notifier_list;
 
 EXPORT_SYMBOL(panic_notifier_list);
#1 lore raw
Quoted 3 lines · Adrian Bunk

I didn't find any possible modular usage in the kernel.

panic_timeout has many in-kernel users and it is used from within a module in 2.4.30.

Hence it is easily possible that some out-of-tree code is dependent upon this export, hence I shan't be applying this patch.

Quoted 12 lines
kernel/panic.c renamed from kernel/panic.c.old +0 -2
@@ -24,8 +24,6 @@
 int panic_on_oops;
 int tainted;
 
-EXPORT_SYMBOL(panic_timeout);
-
 struct notifier_block *panic_notifier_list;
 
 EXPORT_SYMBOL(panic_notifier_list);
#2 lore raw

PATCH 1/1 __deprecated_for_modules panic_timeout

Quoted 10 lines · Andrew Morton
Quoted 3 lines · Adrian Bunk

I didn't find any possible modular usage in the kernel.

panic_timeout has many in-kernel users and it is used from within a module in 2.4.30.

Hence it is easily possible that some out-of-tree code is dependent upon this export, hence I shan't be applying this patch.

Patch to deprecate it is below.

cu
Adrian

<-- snip -->

Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +8 -0
@@ -65,0 +66,8 @@
+
+---------------------------
+
+What:	remove EXPORT_SYMBOL(panic_timeout)
+When:	April 2006
+Files:	kernel/panic.c
+Why:	No modular usage in the kernel.
+Who:	Adrian Bunk <[email protected]>
include/linux/kernel.h renamed from include/linux/kernel.h.old +1 -1
@@ -163 +163 @@
-extern int panic_timeout;
+extern __deprecated_for_modules int panic_timeout;