i810fb: Fix default monitor sync timings

PATCH In review Antonino A. Daplas 1 participant 1 message Apr 16, 2005 Framebuffer layer

lore

Share & tools

lore

Antonino A. Daplas

author

2005-04-16 05:28 UTC #0 lore raw

PATCH 5/6 i810fb: Fix default monitor sync timings

- Increase error message verbosity with respect
to monitor timings.

- Fix default sync timings

From: Denis Vlasenko <[email protected]>

Signed-off-by Antonino Daplas <[email protected]>

---

 i810_main.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

drivers/video/i810/i810_main.c +9 -3

diff -Nru a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
@@ -999,8 +999,14 @@
 	info->monspecs.dclkmin = 15000000;
 
 	if (fb_validate_mode(var, info)) {
-		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info))
+		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info)) {
+			int default_sync = (hsync1-HFMIN)|(hsync2-HFMAX)
+					    |(vsync1-VFMIN)|(vsync2-VFMAX);
+			printk("i810fb: invalid video mode%s\n",
+			    default_sync ? "" :
+			    ". Specifying vsyncN/hsyncN parameters may help");
 			return -EINVAL;
+		}
 	}
 	
 	var->xres = xres;

@@ -2023,10 +2029,10 @@
 		 " (default = 480)");
 module_param(hsync1, int, 0);
 MODULE_PARM_DESC(hsync1, "Minimum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 29)");
 module_param(hsync2, int, 0);
 MODULE_PARM_DESC(hsync2, "Maximum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 30)");
 module_param(vsync1, int, 0);
 MODULE_PARM_DESC(vsync1, "Minimum vertical frequency of monitor in Hz"
 		 " (default = 50)");

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click