Skip to contentSkip to conversation

: Add msi test

TG3 Arjan van de Ven 2 participants 2 messages Apr 22, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Linux Kernel Mailing List

tree 1e1c24ad874db00f827fc6d9087402db6becefc9
parent 88b06bc26b87cf0490b0e3faea7fefc7549dd75d
author Michael Chan <[email protected]> Fri, 22 Apr 2005 07:13:59 -0700 committer David S. Miller <[email protected]> Fri, 22 Apr 2005 07:13:59 -0700

[TG3]: Add msi test

Add MSI test for chips that support MSI. If MSI test fails, it will switch back to INTx mode and will print a message asking the user to report the failure.

While the technicals of this change are ok, this still concerns me. Are all MSI drivers now supposed to check if the bios/mobo actually support MSI like this? That sounds sort of wrong!

#2 lore raw
Quoted 3 lines · On Fri, 22 Apr 2005 09:54:12 +0200 Arjan van de Ven <[email protected]> wrote:

While the technicals of this change are ok, this still concerns me. Are all MSI drivers now supposed to check if the bios/mobo actually support MSI like this? That sounds sort of wrong!

It's a temporary situation I believe. Later on when our blacklist is more comprehensive we can remove this kind of test code.

The test does spit a message out, so we will likely get a report and therefore be able to update our MSI blacklists as appropriate.