Skip to contentSkip to conversation

correct the DEBUG_BUGVERBOSE question dependency

PATCH In review Adrian Bunk 2 participants 3 messages Apr 23, 2005 Library code

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 correct the DEBUG_BUGVERBOSE question dependency

Currently, DEBUG_BUGVERBOSE, is automatically set to "y" if DEBUG_KERNEL=n and EMBEDDED=y which doesn't make much sense.

Signed-off-by Adrian Bunk <[email protected]>
lib/Kconfig.debug renamed from lib/Kconfig.debug.old +1 -1
@@ -125,9 +125,9 @@
 	  This options enables addition error checking for high memory systems.
 	  Disable for production systems.
 
 config DEBUG_BUGVERBOSE
-	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EMBEDDED
+	bool "Verbose BUG() reporting (adds 70K)" if EMBEDDED
 	depends on BUG
 	depends on ARM || ARM26 || M32R || M68K || SPARC32 || SPARC64 || (X86 && !X86_64) || FRV
 	default !EMBEDDED
 	help
#1 lore raw

Hi,

Quoted 8 lines · Adrian Bunk

Currently, DEBUG_BUGVERBOSE, is automatically set to "y" if DEBUG_KERNEL=n and EMBEDDED=y which doesn't make much sense.

Signed-off-by Adrian Bunk <[email protected]>

lib/Kconfig.debug line 133

Quoted 10 lines
lib/Kconfig.debug renamed from lib/Kconfig.debug.old +1 -1
@@ -125,9 +125,9 @@
 	  This options enables addition error checking for high memory systems.
 	  Disable for production systems.
 
 config DEBUG_BUGVERBOSE
-	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EMBEDDED
+	bool "Verbose BUG() reporting (adds 70K)" if EMBEDDED
 	depends on BUG
 	depends on ARM || ARM26 || M32R || M68K || SPARC32 || SPARC64 || (X86 && !X86_64) || FRV
 	default !EMBEDDED
 	help

1. you just messed up the menu structure.
2. the default is "!EMBEDDED", so it should become "n"?!

bye, Roman

author
#2 lore raw
Quoted 15 lines · Roman Zippel

Hi,

Quoted 11 lines · Adrian Bunk

Currently, DEBUG_BUGVERBOSE, is automatically set to "y" if DEBUG_KERNEL=n and EMBEDDED=y which doesn't make much sense.

Signed-off-by Adrian Bunk <[email protected]>
lib/Kconfig.debug renamed from lib/Kconfig.debug.old +0 -0
@@ -125,9 +125,9 @@
 	  This options enables addition error checking for high memory systems.
 	  Disable for production systems.
Quoted 10 lines

lib/Kconfig.debug line 133

Quoted 7 lines
lib/Kconfig.debug renamed from lib/Kconfig.debug.old +1 -1
 config DEBUG_BUGVERBOSE
-	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EMBEDDED
+	bool "Verbose BUG() reporting (adds 70K)" if EMBEDDED
 	depends on BUG
 	depends on ARM || ARM26 || M32R || M68K || SPARC32 || SPARC64 || (X86 && !X86_64) || FRV
 	default !EMBEDDED
 	help

1. you just messed up the menu structure.
2. the default is "!EMBEDDED", so it should become "n"?!

Ups, thanks for the correction.

I didn't see this, and this makes my patch completely pointless.

Quoted 1 line

bye, Roman

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed