Skip to contentSkip to conversation

/proc/net/stat/* cleanup

PATCH In review Olaf Rempel 2 participants 3 messages Mar 4, 2005 – Apr 28, 2005 1 message not in the archive

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Olaf Rempel

author
#0 lore raw

PATCH 1/1 /proc/net/stat/* cleanup

hi list

in /proc/net/stat/[arp|ndisc]_cache the value "forced_gc_goal_miss" has no associated member in struct neigh_statistics.

in /proc/net/stat/rt_cache the value "in_slow_mc" was printed, but without header (16 header-names, 17 values)

patch is against vanilla 2.6.11

Olaf

net/core/neighbour.c 2005-03-04 20:04:17.000000000 +0100 renamed from net/core/neighbour.c.org 2005-03-04 20:03:01.000000000 +0100 +1 -1
diff -uN linux-2.6.11/net/core/neighbour.c.org linux-2.6.11/net/core/neighbour.c
@@ -1948,7 +1948,7 @@
        struct neigh_statistics *st = v;
 
        if (v == SEQ_START_TOKEN) {
-               seq_printf(seq, "entries  allocs destroys hash_grows  lookups hits  res_failed  rcv_probes_mcast rcv_probes_ucast  periodic_gc_runs forced_gc_runs forced_gc_goal_miss\n");
+               seq_printf(seq, "entries  allocs destroys hash_grows  lookups hits  res_failed  rcv_probes_mcast rcv_probes_ucast  periodic_gc_runs forced_gc_runs\n");
                return 0;
        }
net/ipv4/route.c 2005-03-04 19:47:58.000000000 +0100 renamed from net/ipv4/route.c.org 2005-03-04 19:45:54.000000000 +0100 +1 -1
diff -uN linux-2.6.11/net/ipv4/route.c.org linux-2.6.11/net/ipv4/route.c
@@ -393,7 +393,7 @@
        struct rt_cache_stat *st = v;
 
        if (v == SEQ_START_TOKEN) {
-               seq_printf(seq, "entries  in_hit in_slow_tot in_no_route in_brd in_martian_dst in_martian_src  out_hit out_slow_tot out_slow_mc  gc_total gc_ignored gc_goal_miss gc_dst_overflow in_hlist_search out_hlist_search\n");
+               seq_printf(seq, "entries  in_hit in_slow_tot in_slow_mc in_no_route in_brd in_martian_dst in_martian_src  out_hit out_slow_tot out_slow_mc  gc_total gc_ignored gc_goal_miss gc_dst_overflow in_hlist_search out_hlist_search\n");
                return 0;
        }

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw
Quoted 4 lines · On Sun, 24 Apr 2005 19:30:07 -0700 "David S. Miller" <[email protected]>…

Your patch is mangled by your email client, the tabs have been turned into spaces, so the patch will not apply.

Also, please supply a proper "Signed-off-by:" line with your changes.

Whoops. OK

Patch against 2.6.11 vanilla

/proc/net/stat/* header cleanup

Signed-off-by Olaf Rempel <[email protected]>
net/core/neighbour.c renamed from net/core/neighbour.c.org +1 -1
@@ -1948,7 +1948,7 @@
 	struct neigh_statistics *st = v;
 
 	if (v == SEQ_START_TOKEN) {
-		seq_printf(seq, "entries  allocs destroys hash_grows  lookups hits  res_failed  rcv_probes_mcast rcv_probes_ucast  periodic_gc_runs forced_gc_runs forced_gc_goal_miss\n");
+		seq_printf(seq, "entries  allocs destroys hash_grows  lookups hits  res_failed  rcv_probes_mcast rcv_probes_ucast  periodic_gc_runs forced_gc_runs\n");
 		return 0;
 	}
net/ipv4/route.c renamed from net/ipv4/route.c.org +1 -1
@@ -393,7 +393,7 @@
 	struct rt_cache_stat *st = v;
 
 	if (v == SEQ_START_TOKEN) {
-		seq_printf(seq, "entries  in_hit in_slow_tot in_no_route in_brd in_martian_dst in_martian_src  out_hit out_slow_tot out_slow_mc  gc_total gc_ignored gc_goal_miss gc_dst_overflow in_hlist_search out_hlist_search\n");
+		seq_printf(seq, "entries  in_hit in_slow_tot in_slow_mc in_no_route in_brd in_martian_dst in_martian_src  out_hit out_slow_tot out_slow_mc  gc_total gc_ignored gc_goal_miss gc_dst_overflow in_hlist_search out_hlist_search\n");
 		return 0;
 	}
maintainer
#3 lore raw
Quoted 8 lines · On Mon, 25 Apr 2005 19:00:48 +0200 Olaf Rempel <[email protected]> wrote:
Quoted 4 lines · On Sun, 24 Apr 2005 19:30:07 -0700 "David S. Miller" <[email protected]>…

Your patch is mangled by your email client, the tabs have been turned into spaces, so the patch will not apply.

Also, please supply a proper "Signed-off-by:" line with your changes.

Quoted 7 lines

Whoops. OK

Patch against 2.6.11 vanilla

/proc/net/stat/* header cleanup

Signed-off-by Olaf Rempel <[email protected]>

Patch applied, thanks a lot.