Skip to contentSkip to conversation

unexport __print_symbol

PATCH In review Adrian Bunk 2 participants 3 messages Apr 15, 2005 – Apr 25, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unexport __print_symbol

I didn't find any possible modular usage in the kernel.

---

This patch was already sent on:
- 4 Mar 2005

kernel/kallsyms.c renamed from kernel/kallsyms.c.old +0 -1
@@ -408,4 +408,3 @@
 }
 __initcall(kallsyms_init);
 
-EXPORT_SYMBOL(__print_symbol);
#1 lore raw
Quoted 3 lines · Adrian Bunk

I didn't find any possible modular usage in the kernel.

Making print_symbol() available to modules during their development might aid that development. Presumably, such debug code would not appear in the mainline tree.

IOW: people might want to use print_symbol() during private development, so we should continue to export it to modules.

Quoted 8 lines
kernel/kallsyms.c renamed from kernel/kallsyms.c.old +0 -1
@@ -408,4 +408,3 @@
 }
 __initcall(kallsyms_init);
 
-EXPORT_SYMBOL(__print_symbol);
#2 lore raw
Quoted 11 lines · Andrew Morton
Quoted 3 lines · Adrian Bunk

I didn't find any possible modular usage in the kernel.

Making print_symbol() available to modules during their development might aid that development. Presumably, such debug code would not appear in the mainline tree.

IOW: people might want to use print_symbol() during private development, so we should continue to export it to modules.

If you need it during private development, you can always re-add it in your private tree.

And the possibility of such debug code accidentially getting into mainline drops to zero if the EXPORT_SYMBOL isn't there.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed