Skip to contentSkip to conversation

drivers/char/tty_io.c: make a function static

PATCH In review Adrian Bunk 2 participants 3 messages Apr 30, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/tty_io.c: make a function static

This patch makes a needlessly global function static.

---

This patch was already sent on:
- 17 Apr 2005

 drivers/char/tty_io.c |    5 +++--
 include/linux/tty.h   |    2 --
 2 files changed, 3 insertions(+), 4 deletions(-)
include/linux/tty.h renamed from include/linux/tty.h.old +0 -2
@@ -337,8 +337,6 @@
 extern void console_init(void);
 extern int vcs_init(void);
 
-extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
-			      const char *routine);
 extern char *tty_name(struct tty_struct *tty, char *buf);
 extern void tty_wait_until_sent(struct tty_struct * tty, long timeout);
 extern int tty_check_change(struct tty_struct * tty);
drivers/char/tty_io.c renamed from drivers/char/tty_io.c.old +3 -2
@@ -186,8 +186,9 @@
 
 EXPORT_SYMBOL(tty_name);
 
-inline int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
-			      const char *routine)
+static inline int tty_paranoia_check(struct tty_struct *tty,
+				     struct inode *inode,
+				     const char *routine)
 {
 #ifdef TTY_PARANOIA_CHECK
 	if (!tty) {
#1 lore raw
Quoted 6 lines · Adrian Bunk

This patch makes a needlessly global function static.

...
-extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine);

Is used in fs/compat_ioct.c.

#2 lore raw
Quoted 9 lines · Andrew Morton
Quoted 6 lines · Adrian Bunk

This patch makes a needlessly global function static.

...
-extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine);

Is used in fs/compat_ioct.c.

Sorry.

I missed this while grepping and it didn't show up in my i386 test compiles.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed