Skip to contentSkip to conversation

drivers/block/rd.c: make a variable static

PATCH New Adrian Bunk 2 participants 2 messages May 2, 2005 – May 6, 2005 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/block/rd.c: make a variable static

This patch makes a needlessly global variable static.

---

This patch was already sent on:
- 10 Apr 2005

drivers/block/rd.c renamed from drivers/block/rd.c.old +1 -1
@@ -74,7 +74,7 @@
  * architecture-specific setup routine (from the stored boot sector
  * information).
  */
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;		/* Size of the RAM disks */
+static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;	/* Size of the RAM disks */
 /*
  * It would be very desirable to have a soft-blocksize (that in the case
  * of the ramdisk driver is also the hardblocksize ;) of PAGE_SIZE because
#1 lore raw

PATCH 1/1 drivers/block/rd.c: don't make a variable static

Quoted 11 lines · Adrian Bunk

This patch makes a needlessly global variable static.

--- linux-2.6.12-rc2-mm2-full/drivers/block/rd.c.old 2005-04-10
02:00:08.000000000 +0200 +++
linux-2.6.12-rc2-mm2-full/drivers/block/rd.c 2005-04-10 02:01:00.000000000
+0200 @@ -74,7 +74,7 @@
* architecture-specific setup routine (from the stored boot sector
* information).
*/

Review

Quoted 5 lines
(quoted diff) +1 -1
-int rd_size = CONFIG_BLK_DEV_RAM_SIZE;		/* Size of the RAM disks */
+static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;	/* Size of the RAM disks */
 /*
  * It would be very desirable to have a soft-blocksize (that in the case
  * of the ramdisk driver is also the hardblocksize ;) of PAGE_SIZE because

This patch breaks PPC iSeries in arch/ppc64/kernel/iSeries_setup.c

drivers/block/rd.c +1 -1
@@ -74,7 +74,7 @@
  * architecture-specific setup routine (from the stored boot sector
  * information).
  */
-static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;	/* Size of the RAM disks */
+int rd_size = CONFIG_BLK_DEV_RAM_SIZE;		/* Size of the RAM disks */
 /*
  * It would be very desirable to have a soft-blocksize (that in the case
  * of the ramdisk driver is also the hardblocksize ;) of PAGE_SIZE because