Skip to contentSkip to conversation

I2C: remove <linux/delay.h> from via686a

PATCH New Grant Coady 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C: remove <linux/delay.h> from via686a

Hi Greg,

In my cross-reference checking of sysfs names, the via686a needs special case treatment as it the only driver expands S_IWUSR to 00200 with gcc -E. (00200 is the correct value for S_IWUSR).

This is caused by the driver including <linux/delay.h>, it compiles fine without that header but I am unable to test drive the change.

--Grant.

---
 via686a.c |    1 -
 1 files changed, 1 deletion(-)
drivers/i2c/chips/via686a.c +0 -1
@@ -33,7 +33,6 @@
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/pci.h>
-#include <linux/delay.h>
 #include <linux/jiffies.h>
 #include <linux/i2c.h>
 #include <linux/i2c-sensor.h>
#1 lore raw

PATCH 1/1 I2C: remove <linux/delay.h> from via686a

Hi Grant,

Quoted 6 lines

In my cross-reference checking of sysfs names, the via686a needs special case treatment as it the only driver expands S_IWUSR to 00200 with gcc -E. (00200 is the correct value for S_IWUSR).

This is caused by the driver including <linux/delay.h>, it compiles fine without that header but I am unable to test drive the change.

Although your reason for removing that include is bad, it is actually correct to remove it, because we don't need it. I've removed it from the lm_sensors CVS driver as well.

Thanks,

Signature · 1 line
Jean Delvare