Skip to contentSkip to conversation

compiling problem fixed

PATCH Applied Martin Langer 2 participants 4 messages May 3, 2005 – May 12, 2005

lore
Share & tools
lore

Martin Langer

author
#0 lore raw

PATCH 1/1 compiling problem fixed

This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.

Signed-off-by Martin Langer <[email protected]>
adriver.h renamed from adriver.h.ORIGINAL +1 -0
@@ -23,6 +23,7 @@
  */
 
 #include <linux/version.h>
+#include <linux/slab.h>
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 2, 3)
 #error "This driver requires Linux 2.2.3 or higher."
#1 lore raw

At Tue, 3 May 2005 16:29:16 +0200,

Quoted 9 lines · Martin Langer

[1 <text/plain; us-ascii (7bit)>]
This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.

Signed-off-by Martin Langer <[email protected]>
[2 adriver.patch <text/plain; us-ascii (7bit)>]

adriver.h line 29

Quoted 7 lines
adriver.h renamed from adriver.h.ORIGINAL +1 -0
@@ -23,6 +23,7 @@
  */
 
 #include <linux/version.h>
+#include <linux/slab.h>
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 2, 3)
 #error "This driver requires Linux 2.2.3 or higher."

It's not nice to put to this place. It always includes the file.

Where does this error happen? In the gameport wrapper inline function? If so, try to include just before it so that it doesn't affect to other kernel versions.

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click

author
#2 lore raw
Quoted 6 lines · Takashi Iwai

At Tue, 3 May 2005 16:29:16 +0200,

Quoted 2 lines · Martin Langer

This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.

It's not nice to put to this place. It always includes the file.

Ah sorry, I see your point. Next time I should scroll down in my editor, before I create a patch :)

Quoted 2 lines

Where does this error happen? In the gameport wrapper inline function?

Yep, it's in the gameport wrapper inline function. So now it's placed closer to that wrapper function.

---
Fix undeclared GFP_KERNEL in gameport wrapper inline function. Compile error happened with debian kernel 2.4.27 (alpha cpu).

Signed-off-by Martin Langer <[email protected]>

---

BTW, the miroSOUND PCM12 with the new miro driver is running great, even on my alpha machine here :)

martin

adriver.h renamed from adriver.h.ORIGINAL +1 -0
@@ -749,6 +749,7 @@
 #include <linux/gameport.h>
 #undef wait_ms
 #ifndef to_gameport_driver
+#include <linux/slab.h>
 /* old gameport interface */
 struct snd_gameport {
 	struct gameport gp;
Applied
#3 lore raw

At Wed, 11 May 2005 20:54:59 +0200,

Quoted 9 lines · Martin Langer
Quoted 6 lines · Takashi Iwai

At Tue, 3 May 2005 16:29:16 +0200,

Quoted 2 lines · Martin Langer

This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.

It's not nice to put to this place. It always includes the file.

Quoted 8 lines

Ah sorry, I see your point. Next time I should scroll down in my editor, before I create a patch :)

Quoted 2 lines

Where does this error happen? In the gameport wrapper inline function?

Yep, it's in the gameport wrapper inline function. So now it's placed closer to that wrapper function.

Thanks, applied now to CVS.

Quoted 3 lines

BTW, the miroSOUND PCM12 with the new miro driver is running great, even on my alpha machine here :)

Good to hear ;)

ciao,

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes Want to be the first software developer in space? Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click