Skip to contentSkip to conversation

2.4.30 xfs bug

DISCUSSION Russell Miller 2 participants 2 messages May 12, 2005 – May 18, 2005 XFS filesystem

lore
Share & tools
lore
#0 lore raw

2.4.30 will not compile if XFS is turned on, but XFS debugging is not. Culprit is:

fs/xfs/linux-2.4/xfs_buf.c line 1076. Apparently pagebuf_lock_value is used somewhere else, even if it's not defined because debugging is off.

--Russell

#1 lore raw
Quoted 5 lines · Russell Miller

2.4.30 will not compile if XFS is turned on, but XFS debugging is not. Culprit is:

fs/xfs/linux-2.4/xfs_buf.c line 1076. Apparently pagebuf_lock_value is used somewhere else, even if it's not defined because debugging is off.

Looks like a trivial one-liner got lost when merging from the SGI CVS tree.

Macelo, can you apply this little patch below?

fs/xfs/linux-2.4/xfs_buf.c +1 -1
@@ -1073,7 +1073,7 @@ pagebuf_cond_lock(			/* lock buffer, if 
 	return(locked ? 0 : -EBUSY);
 }
 
-#ifdef DEBUG
+#if defined(DEBUG) || defined(XFS_BLI_TRACE)
 /*
  *	pagebuf_lock_value
  *