Skip to contentSkip to conversation

I2C: Setting w83627hf fan divisor 128 fails.

PATCH New Grant Coady 2 participants 2 messages May 19, 2005

lore
Share & tools
lore

Grant Coady

author
#0 lore raw

PATCH 1/1 I2C: Setting w83627hf fan divisor 128 fails.

Hi all,

Jarkko Lavinen provided patch to fix: "couldn't set the divisor 128 through fan1_div sysfs entry even though the chip supports it and setting divisors 1..64 worked. This was due to POWER_TO_REG() only checking 2's powers 0 till 5 but not 6."

This patch applies that fix to w83627hf and w83781d drivers.

--Grant.

Signed-off-by Grant Coady <[email protected]>
---
 w83627hf.c |    2 +-
 w83781d.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/chips/w83627hf.c +1 -1
diff -X dontdiff -Nru linux-2.6.12-rc4/drivers/i2c/chips/w83627hf.c linux-2.6.12-rc4b/drivers/i2c/chips/w83627hf.c
@@ -264,7 +264,7 @@
 {
 	int i;
 	val = SENSORS_LIMIT(val, 1, 128) >> 1;
-	for (i = 0; i < 6; i++) {
+	for (i = 0; i < 7; i++) {
 		if (val = 0)
 			break;
 		val >>= 1;
drivers/i2c/chips/w83781d.c +1 -1
diff -X dontdiff -Nru linux-2.6.12-rc4/drivers/i2c/chips/w83781d.c linux-2.6.12-rc4b/drivers/i2c/chips/w83781d.c
@@ -193,7 +193,7 @@
 	val = SENSORS_LIMIT(val, 1,
 			    ((type = w83781d
 			      || type = as99127f) ? 8 : 128)) >> 1;
-	for (i = 0; i < 6; i++) {
+	for (i = 0; i < 7; i++) {
 		if (val = 0)
 			break;
 		val >>= 1;
Applied
#1 lore raw

PATCH 1/1 I2C: Setting w83627hf fan divisor 128 fails.

Hi Grant,

Quoted 6 lines

Jarkko Lavinen provided patch to fix: "couldn't set the divisor 128 through fan1_div sysfs entry even though the chip supports it and setting divisors 1..64 worked. This was due to POWER_TO_REG() only checking 2's powers 0 till 5 but not 6."

This patch applies that fix to w83627hf and w83781d drivers.

Applied, thanks.

Signature · 1 line
Jean Delvare