Status of net/ipv4/ipvs/ip_vs_proto_icmp.c?
Subsystems (2)
Hi,
can anyone explain the status of?
This file is always included in the kernel if CONFIG_IP_VS=y, but it's completely unused.
Will it be made working in the forseeable future or is it a candidate for removal?
TIA
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines · Adrian Bunk
Hi,
can anyone explain the status of?
Quoted 8 lines
This file is always included in the kernel if
CONFIG_IP_VS=y, but it's completely unused.Will it be made working in the forseeable future or is it a candidate for removal?
TIA
Adrian
The people/places to ask would probably be:
IPVS
P: Wensong Zhang M: [email protected] P: Julian Anastasov M: [email protected] S: Maintained
or
Quoted 17 lines · Andres Salomon
Quoted 4 lines · Adrian Bunk
Hi,
can anyone explain the status of?
Quoted 8 lines
This file is always included in the kernel if
CONFIG_IP_VS=y, but it's completely unused.Will it be made working in the forseeable future or is it a candidate for removal?
TIA
AdrianThe people/places to ask would probably be:
Quoted 7 lines
IPVS
P: Wensong Zhang M: [email protected] P: Julian Anastasov M: [email protected] S: Maintained...
And these are exactly the people in the To-header of the email asking this question.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedHello,
Quoted 2 lines · Adrian Bunk
Will it be made working in the forseeable future or is it a candidate for removal?
IMO, it can be removed as it was never finished. We can always
add it later.
Regards
--
Julian Anastasov <[email protected]>
PATCH 1/1 remove net/ipv4/ipvs/ip_vs_proto_icmp.c?
Quoted 10 lines · Julian Anastasov
Hello,
Quoted 2 lines · Adrian Bunk
Will it be made working in the forseeable future or is it a candidate for removal?
IMO, it can be removed as it was never finished. We can always
add it later.
Thanks for the confirmation.
A patch to remove it is below.
Quoted 2 lines
Regards
Julian Anastasov <[email protected]>
cu
Adrian
<-- snip -->
ip_vs_proto_icmp.c was never finished.
---
net/ipv4/ipvs/Makefile | 2 net/ipv4/ipvs/ip_vs_proto.c | 3 net/ipv4/ipvs/ip_vs_proto_icmp.c | 182 ------------------------------- 3 files changed, 1 insertion(+), 186 deletions(-)
net/ipv4/ipvs/Makefile renamed from net/ipv4/ipvs/Makefile.old +1 -1
@@ -11,7 +11,7 @@ ip_vs-objs := ip_vs_conn.o ip_vs_core.o ip_vs_ctl.o ip_vs_sched.o \ ip_vs_xmit.o ip_vs_app.o ip_vs_sync.o \ - ip_vs_est.o ip_vs_proto.o ip_vs_proto_icmp.o \ + ip_vs_est.o ip_vs_proto.o \ $(ip_vs_proto-objs-y)
net/ipv4/ipvs/ip_vs_proto.c renamed from net/ipv4/ipvs/ip_vs_proto.c.old +0 -3
@@ -216,9 +216,6 @@#ifdef CONFIG_IP_VS_PROTO_UDP REGISTER_PROTOCOL (&ip_vs_protocol_udp);#endif -#ifdef CONFIG_IP_VS_PROTO_ICMP -REGISTER_PROTOCOL (&ip_vs_protocol_icmp); -#endif #ifdef CONFIG_IP_VS_PROTO_AH REGISTER_PROTOCOL (&ip_vs_protocol_ah);#endif
net/ipv4/ipvs/ip_vs_proto_icmp.c deleted +0 -182
182 lines not on this page · raw message
Re: [2.6 patch] remove net/ipv4/ipvs/ip_vs_proto_icmp.c?
From: Adrian Bunk <[email protected]>
Date: Sun, 15 May 2005 15:29:06 +0200
Quoted 3 lines
ip_vs_proto_icmp.cwas never finished.Signed-off-by Adrian Bunk <[email protected]>
Applied, thanks Adrian.