Skip to contentSkip to conversation

DISCUSSION [email protected] 1 participant 1 message May 24, 2005

lore
Share & tools
lore
#0 lore raw
	by smtp.nexlab.net (Postfix) with ESMTP id 1014BFB6D

	for <[email protected]>; Tue, 24 May 2005 10:01:44 +0200 (CEST)

Received: ([email protected]) by vger.kernel.org via listexpand

	id S261278AbVEXBWc (ORCPT <rfc822;[email protected]>);

	Mon, 23 May 2005 21:22:32 -0400

Received: ([email protected]) by vger.kernel.org id S261271AbVEXBWc

	(ORCPT <rfc822;linux-kernel-outgoing>);

	Mon, 23 May 2005 21:22:32 -0400

Received: from fire.osdl.org ([65.172.181.4]:44189 "EHLO smtp.osdl.org")

	by vger.kernel.org with ESMTP id S261329AbVEXBRo (ORCPT

	<rfc822;[email protected]>);

	Mon, 23 May 2005 21:17:44 -0400

Received: from shell0.pdx.osdl.net (fw.osdl.org [65.172.181.6])

	by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id j4O1HBjA004584

	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);

	Mon, 23 May 2005 18:17:12 -0700

Received: from shell0.pdx.osdl.net (localhost [127.0.0.1])

	by shell0.pdx.osdl.net (8.13.1/8.11.6) with ESMTP id j4O1HBxQ031844;

	Mon, 23 May 2005 18:17:11 -0700

Received: (from chrisw@localhost)

	by shell0.pdx.osdl.net (8.13.1/8.13.1/Submit) id j4O1HB9g031843;

	Mon, 23 May 2005 18:17:11 -0700

Date: Mon, 23 May 2005 18:17:11 -0700

From: Chris Wright <[email protected]>
To: Al Viro <[email protected]>
Cc: Chris Wright <[email protected]>, [email protected],
[email protected], Justin Forbes <[email protected]>, Zwane Mwaikambo <[email protected]>,
"Theodore Ts'o" <[email protected]>, Randy Dunlap <[email protected]>, Chuck Wolber <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [patch 06/16] Fix matroxfb on big-endian hardware

Message-ID: <[email protected]>

References: <[email protected]> <[email protected]> <[email protected]>

Mime-Version: 1.0

Content-Type: text/plain; charset=us-ascii

Content-Disposition: inline

In-Reply-To: <[email protected]>

User-Agent: Mutt/1.5.6i

X-Spam-Status: No, hits=0 required=5 tests=

X-Spam-Checker-Version: SpamAssassin 2.63-osdl_revision__1.40__

X-MIMEDefang-Filter: osdl$Revision: 1.109 $

X-Scanned-By: MIMEDefang 2.36

Sender: [email protected]
Precedence: bulk

X-Mailing-List: [email protected]

Quoted 18 lines · * Al Viro ([email protected]) wrote:

Review

Quoted 6 lines · Chris Wright
(quoted diff) +5 -1
-				mga_writel(mmio, 0, *chardata);
+#if defined(__BIG_ENDIAN)
+				fb_writel((*chardata) << 24, mmio.vaddr);
+#else
+				fb_writel(*chardata, mmio.vaddr);
+#endif

So basically you are passing it cpu_to_le32(*chardata)?

Review

Quoted 5 lines
(quoted diff) +5 -0
+#if defined(__BIG_ENDIAN)
+				fb_writel((*(u_int16_t*)chardata) << 16, mmio.vaddr);
+#else
+				fb_writel(*(u_int16_t*)chardata, mmio.vaddr);
+#endif

*yuck*

Quoted 2 lines

cpu_to_le32(le16_to_cpu(*(__le16 *)chardata)? Is that what you are doing here?

Petr, care to comment? Best I can tell this is from you and is already upstream. Any reason not to use cpu_to_xx instead of what's done? -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/