Skip to contentSkip to conversation

DISCUSSION [email protected] 1 participant 1 message May 24, 2005

lore
Share & tools
lore
#0 lore raw
	by smtp.nexlab.net (Postfix) with ESMTP id 9E548FB76

	for <[email protected]>; Tue, 24 May 2005 10:01:47 +0200 (CEST)

Received: ([email protected]) by vger.kernel.org via listexpand

	id S261380AbVEXHLm (ORCPT <rfc822;[email protected]>);

	Tue, 24 May 2005 03:11:42 -0400

Received: ([email protected]) by vger.kernel.org id S261383AbVEXHLm

	(ORCPT <rfc822;linux-kernel-outgoing>);

	Tue, 24 May 2005 03:11:42 -0400

Received: from wproxy.gmail.com ([64.233.184.198]:55599 "EHLO wproxy.gmail.com")

	by vger.kernel.org with ESMTP id S261380AbVEXHLf convert rfc822-to-8bit

	(ORCPT <rfc822;[email protected]>);

	Tue, 24 May 2005 03:11:35 -0400

Received: by wproxy.gmail.com with SMTP id 68so2499905wri

        for <[email protected]>; Tue, 24 May 2005 00:11:34 -0700 (PDT)

DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;

        s=beta; d=gmail.com;

        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;

        b=tvIhVOeAzDNbsvJvSQ5uiPWVf1N9fUHV/ILTH1RV6NCU8oFfa/Deuwxu8gnPnKO2oOPcW9uTpMLIC9RWUkUYORUvUUF5ovlT66teN2p4kc1mPLda7J/oL/8dMHdOkC54WTfaWuiTjdCwq+AD65PTFOYTBk4bAGyeGa/JpWda7Uo=

Received: by 10.54.37.78 with SMTP id k78mr3954580wrk;

        Tue, 24 May 2005 00:11:34 -0700 (PDT)

Received: by 10.54.66.13 with HTTP; Tue, 24 May 2005 00:11:34 -0700 (PDT)

Message-ID: <[email protected]>

Date: Tue, 24 May 2005 10:11:34 +0300

From: Pekka Enberg <[email protected]>
Reply-To: Pekka Enberg <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: [RFC][patch 4/7] v9fs: VFS superblock operations (2.0-rc6)

Cc: [email protected],
[email protected], [email protected], [email protected], [email protected]
In-Reply-To: <[email protected]>

Mime-Version: 1.0

Content-Type: text/plain; charset=US-ASCII

Content-Transfer-Encoding: 7BIT

Content-Disposition: inline

References: <[email protected]>

Sender: [email protected]
Precedence: bulk

X-Mailing-List: [email protected]

Hi,

Quoted 17 lines · On 5/24/05, [email protected] <[email protected]> wrote:

Index: fs/9p/v9fs.c
===================================================================

fs/9p/v9fs.c (mode:100644) renamed from dev/null (tree:0bf32353105286a5624aeea862d35a4bbae09851) +12 -0
@@ -0,0 +1,573 @@
+/*
+  * Fcall Slab Accounting
+  */
+
+struct v9fs_slab {
+       struct list_head list;
+
+       int size;
+       kmem_cache_t *slab;
+};
+
+static LIST_HEAD(v9fs_slab_list);

[snip]

fs/9p/v9fs.c (mode:100644)

Quoted 8 lines
fs/9p/v9fs.c (mode:100644) renamed from dev/null (tree:0bf32353105286a5624aeea862d35a4bbae09851) +8 -0
+
+/**
+ * find_slab - look up a slab by size
+ * @size: size of slab data
+ *
+ */
+
+static inline kmem_cache_t *find_slab(int size)

Hmm? Why do you need this? If you're missing functionality from the slab allocator, please put that in mm/slab.c, not your filesystem!

Quoted 2 lines
fs/9p/v9fs.c (mode:100644) renamed from dev/null (tree:0bf32353105286a5624aeea862d35a4bbae09851) +2 -0
+void v9fs_session_close(struct v9fs_session_info *v9ses)
+{

[snip]

fs/9p/v9fs.c (mode:100644)

Quoted 3 lines
fs/9p/v9fs.c (mode:100644) renamed from dev/null (tree:0bf32353105286a5624aeea862d35a4bbae09851) +3 -0
+       if (v9ses->name) {
+               kfree(v9ses->name);
+       }

kfree() handles NULL pointers just fine, so please drop the redundant check (here and in various other places too).

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/