Skip to contentSkip to conversation

DISCUSSION [email protected] 1 participant 1 message May 24, 2005

lore
Share & tools
lore
#0 lore raw
	by smtp.nexlab.net (Postfix) with ESMTP id D9E1AFA5A

	for <[email protected]>; Tue, 24 May 2005 06:39:35 +0200 (CEST)

Received: ([email protected]) by vger.kernel.org via listexpand

	id S261346AbVEXDUv (ORCPT <rfc822;[email protected]>);

	Mon, 23 May 2005 23:20:51 -0400

Received: ([email protected]) by vger.kernel.org id S261338AbVEXDUv

	(ORCPT <rfc822;linux-kernel-outgoing>);

	Mon, 23 May 2005 23:20:51 -0400

Received: from mx1.redhat.com ([66.187.233.31]:12499 "EHLO mx1.redhat.com")

	by vger.kernel.org with ESMTP id S261324AbVEXDUi (ORCPT

	<rfc822;[email protected]>);

	Mon, 23 May 2005 23:20:38 -0400

Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])

	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4O3KR8X000397;

	Mon, 23 May 2005 23:20:27 -0400

Received: from mail.boston.redhat.com (mail.boston.redhat.com [172.16.76.12])

	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4O3KRO05468;

	Mon, 23 May 2005 23:20:27 -0400

Received: from thoron.boston.redhat.com (thoron.boston.redhat.com [172.16.80.63])

	by mail.boston.redhat.com (8.12.8/8.12.8) with ESMTP id j4O3KQpW029577;

	Mon, 23 May 2005 23:20:26 -0400

Date: Mon, 23 May 2005 23:20:26 -0400 (EDT)

From: James Morris <[email protected]>
X-X-Sender: [email protected]

To: Herbert Xu <[email protected]>
Cc: Andrew Morton <[email protected]>, <[email protected]>,
<[email protected]>, <[email protected]>
Subject: Re: [CRYPTO]: Only reschedule if !in_atomic()

In-Reply-To: <[email protected]>

Message-ID: <[email protected]>

MIME-Version: 1.0

Content-Type: TEXT/PLAIN; charset=US-ASCII

Sender: [email protected]
Precedence: bulk

X-Mailing-List: [email protected]

Quoted 13 lines · Herbert Xu
Quoted 3 lines · Andrew Morton

Are you sure it's actually needed? Have significant scheduling latencies actually been observed?

I certainly don't have any problems with removing the yield altogether.

Quoted 5 lines

Bear in mind that anyone who cares a lot about latency will be running CONFIG_PREEMPT kernels, in which case the whole thing is redundant anyway. I generally take the position that if we're going to put a scheduling point into a non-premept kernel then it'd better be for a pretty bad latency point - more than 10 milliseconds, say.

Quoted 4 lines

The crypt() function can easily take more than 10 milliseconds with a large enough buffer.

James & Dave, do you have any opinions on this?

a) remove the scheudling point and see if anyone complains
b) if so, add a flag

- James

Signature · 9 lines
James Morris
<[email protected]>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/